Commit graph

5 commits

Author SHA1 Message Date
HAOYUatHZ
b22944a621
Revert "Substitute secp256k1 library for the L1 version (#22)" (#290)
* Revert "Substitute secp256k1 library for the L1 version (#22)"

This reverts commit 59df2d7ebb.

* goimports -local github.com/scroll-tech/go-ethereum -w .

* go mod tidy
2023-04-19 15:54:20 +08:00
Jules
59df2d7ebb
Substitute secp256k1 library for the L1 version (#22)
* Substitute secp256k1 library for the L1 version

* Add explanatory comment for secp256k1 library change

* Update secp_fuzzer.go

* Change to go-ethereum version 1.10.13

Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
2022-02-09 15:03:42 +08:00
Felix Lange
8a134014b4
all: add go:build lines (#23468)
Generated by go1.17 fmt ./...
2021-08-25 18:46:29 +02:00
Martin Holst Swende
a750bf8686
crypto: fix build directives 2021-06-22 15:21:11 +02:00
Marius van der Wijden
0703ef62d3
crypto/secp256k1: fix undefined behavior in BitCurve.Add (#22621)
This commit changes the behavior of BitCurve.Add to be more inline
with btcd. It fixes two different bugs:

1) When adding a point at infinity to another point, the other point
   should be returned. While this is undefined behavior, it is better
   to be more inline with the go standard library.
   Thus (0,0) + (a, b) = (a,b)

2) Adding the same point to itself produced the point at infinity.
   This is incorrect, now doubleJacobian is used to correctly calculate it.
   Thus (a,b) + (a,b) == 2* (a,b) and not (0,0) anymore.

The change also adds a differential fuzzer for Add, testing it against btcd.

Co-authored-by: Felix Lange <fjl@twurst.com>
2021-05-27 13:30:25 +02:00