* Revert "Substitute secp256k1 library for the L1 version (#22)"
This reverts commit 59df2d7ebb.
* goimports -local github.com/scroll-tech/go-ethereum -w .
* go mod tidy
* Substitute secp256k1 library for the L1 version
* Add explanatory comment for secp256k1 library change
* Update secp_fuzzer.go
* Change to go-ethereum version 1.10.13
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
This commit changes the behavior of BitCurve.Add to be more inline
with btcd. It fixes two different bugs:
1) When adding a point at infinity to another point, the other point
should be returned. While this is undefined behavior, it is better
to be more inline with the go standard library.
Thus (0,0) + (a, b) = (a,b)
2) Adding the same point to itself produced the point at infinity.
This is incorrect, now doubleJacobian is used to correctly calculate it.
Thus (a,b) + (a,b) == 2* (a,b) and not (0,0) anymore.
The change also adds a differential fuzzer for Add, testing it against btcd.
Co-authored-by: Felix Lange <fjl@twurst.com>