Commit graph

658 commits

Author SHA1 Message Date
colin
bdf64cfb39
fix(GPO): make default gas tip configurable (#1096)
* fix(GPO): increase min suggested tip to 100 wei

* chore: auto version bump [bot]

* make DefaultGasTip configurable

* revert a comment change

* fix unit tests

* rename GasTip to GasTipCap, more consistent with geth naming conventions

* yet another comment tweak

* tweak

* address comments

* another

* make defaultGasTipCap.Int64 >0

---------

Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
2024-12-10 18:43:12 +08:00
colin
a5ecce2dc3
fix(async-ccc): print whole block hash and tx hash when failure (#1097)
* fix-async-ccc-print-whole-block-hash-and-tx-hash

* chore: auto version bump [bot]

* chore: auto version bump [bot]

---------

Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
2024-12-06 17:06:35 +08:00
georgehao
17ac3e67a9
feat(txpool): add logs to track txns (#1046)
* add log for txpool tx track

* chore: auto version bump [bot]

* Update core/tx_pool.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* Update core/tx_pool.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* chore: auto version bump [bot]

* address comment

* update level

* update

* tweak logs and print whole tx hashes

* fix a bug

* tweaks

* fix a nil pointer bug

---------

Co-authored-by: georgehao <georgehao@users.noreply.github.com>
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: colinlyguo <colinlyguo@scroll.io>
2024-12-06 16:39:19 +08:00
colin
d2fe42ba8f
internal/ethapi: eth_call block parameter is optional (#28165) (#1095)
* internal/ethapi: eth_call block parameter is optional (#28165)

So apparently in the spec the base block parameter of eth_call is optional.
I agree that "latest" is a sane default for this that most people would use.

* chore: auto version bump [bot]

---------

Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com>
Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
2024-12-03 14:32:37 +08:00
Morty
9fff27e4f3
fix(api): change gas_price to use pending block (#1082)
* fix(api): change gas_price to use pending block
2024-10-29 16:07:33 +08:00
Ömer Faruk Irmak
f00dc06628
fix: account for tx subcircuit confidence factor (#1065) 2024-10-11 09:19:04 +03:00
Péter Garamvölgyi
2ed7456a4b
feat: update L2 base fee formula (#1053)
* feat: update L2 base fee formula

* update 1559 unit test

* use current block's base fee in txpool

* fix unit test

* Revert "use current block's base fee in txpool"

This reverts commit 8a7d7ff87d6a9fb5124d72767c9ca24302673752.
2024-10-01 13:20:20 -07:00
colin
cf1ca84e0e
feat: allow changing L1 synced height via admin RPC/CLI (#1044)
* feat: allow changing L1 synced height via RPC/CLI

* chore: auto version bump [bot]

* fix typos

* add height validity check

* change implementation

* moved hotfix apis from ScrollAPI to PrivateAdminAPI

* change namespace from scroll to admin

* fix bugs

* add locks

* add a lock to protect latestProcessedBlock and db state

* revert some changes

* remove lock and use atomic in latestProcessedBlock

* fix CI

* tweak

* use cas in updating latestProcessedBlock

* renaming

* also update sync height in error paths

* fix a bug

* use mutex lock

---------

Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
2024-09-25 03:18:37 +08:00
Ömer Faruk Irmak
7ff93ca224
fix: initialize pending block with an empty block (#1052) 2024-09-20 17:19:50 +03:00
Ömer Faruk Irmak
c0094ee0b4
fix: avoid committing empty blocks after the deadline (#1051) 2024-09-20 14:59:23 +03:00
Ömer Faruk Irmak
d599666894
fix: make reorg mode explicit (#1049) 2024-09-20 10:19:05 +03:00
colin
f044582cf9
fix: remove a duplicated cmd in Dockerfile.mockccc (#1048)
* fix: remove a duplicated cmd in Dockerfile.mockccc

* increase version
2024-09-20 14:59:44 +08:00
colin
86965f8a48
feat(tx-pool): fast reject transactions that cannot fit into a block (#1042)
* feat(tx pool): fast reject transactions that cannot fit into a block

* add a TestValidateTxBlockSize unit test

* chore: auto version bump [bot]

---------

Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
2024-09-17 23:43:54 +08:00
colin
1d02d04b5d
feat(scroll-worker): add nil consumption block metrics (#1033)
* feat(scroll-worker): add nil consumption block metrics

* increase the version
2024-09-17 22:03:15 +08:00
Ömer Faruk Irmak
521a074f60
feat: allow removing txns from pool via CLI/RPC (#1041) 2024-09-16 13:56:11 +03:00
Ömer Faruk Irmak
7f79c7f21f
refactor: eliminate double re-execution in AsyncChecker (#1036) 2024-09-16 11:04:25 +03:00
Ömer Faruk Irmak
51082b29c5
fix: properly handle wrapped retryable errors (#1030)
* fix: properly handle wrapped retryable errors

* chore: auto version bump [bot]

---------

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: Thegaram <Thegaram@users.noreply.github.com>
2024-09-09 18:37:32 +02:00
Zhang Zhuo
665f6c3413
feat(rpc): add getTxByTxTrace api, used for ccc testing & debugging (#1026)
* ++

* upgrade go lint version

* lint

* remove a useless "`"

* Update l2geth_ci.yml

---------

Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
2024-09-06 23:22:47 +08:00
Ömer Faruk Irmak
a4b738f815
fix: skip ccc.ErrUnknown txns immediately (#1027) 2024-09-06 16:12:53 +03:00
Ömer Faruk Irmak
bf5cca7c29
fix: nil-check curRc (#1024)
* fix: nil-check curRc

* chore: auto version bump [bot]

---------

Co-authored-by: omerfirmak <omerfirmak@users.noreply.github.com>
2024-09-05 15:15:24 -07:00
Ömer Faruk Irmak
bdb1ffb97a
feat: add miner idle metric (#1023) 2024-09-05 17:50:04 +03:00
Ömer Faruk Irmak
e0203bf9b7
feat: double check ancestor RowConsumption before committing (#1022) 2024-09-05 16:54:12 +03:00
HAOYUatHZ
8f8ef30931
feat(txpool): add more logs to runReorg (#1019)
* feat(txpool): add more logs to `runReorg`

* chore: auto version bump [bot]

* improve

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
2024-09-05 09:31:49 +10:00
Ömer Faruk Irmak
e9259b783f
feat: implement and integrate counter-based CCC (#982)
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
Co-authored-by: Xi Lin <zimpha@gmail.com>
2024-09-04 13:33:51 +03:00
HAOYUatHZ
2865e13e5b
fix(metrics): fix tx broadcast investigation metrics again (#1012)
* update eth/protocols/eth/broadcast.go

* chore: auto version bump [bot]

* update eth/protocols/eth/handlers.go

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
2024-08-28 20:17:49 +10:00
HAOYUatHZ
89e9a21577
fix(metrics): fix tx broadcast investigation metrics (#1010)
* update eth/protocols/eth/broadcast.go

* update eth/protocols/eth/handlers.go

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
2024-08-28 15:11:35 +10:00
HAOYUatHZ
118a80b734
feat: add more metrics to investigate tx broadcast issue (#1007)
* update eth/fetcher/tx_fetcher.go

* update eth/handler.go

* update eth/handler.go

* update eth/protocols/eth/peer.go

* update eth/protocols/eth/broadcast.go

* update eth/protocols/eth/handlers.go

* chore: auto version bump [bot]

* fix

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
2024-08-27 23:03:26 +02:00
HAOYUatHZ
77a565943f
feat: add more logs to investigate tx broadcast issue (#1005)
* 1. broadcast + announce

* 2. broadcast

* 3. broadcast

* 5. announce

* 6. announce

* 7. announce

* 8. announce

* 9. announce

* 10. announce

* minor

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
2024-08-27 14:06:13 +02:00
colin
c252ee1ee0
feat(tx-pool): fast reject known skipped txs (#1004)
* feat(tx-pool): fast reject known skipped txs (#1001)

* feat(tx-pool): fast reject known skipped txs

* fix make lint

* add miner flag to tx pool

* bump version
2024-08-26 22:48:44 +08:00
Péter Garamvölgyi
ff23c5272a
feat: schedule DarwinV2 (#1002)
* refactor: add darwinV2 to tests, improve log format

* feat: schedule DarwinV2
2024-08-26 16:15:56 +02:00
colin
03f3b2b60d
fix(rollup-verifier): delete committed batch meta when reverting a batch (#1000)
* fix(rollup-verifier): delete committed batch metadata when reverting a batch

* chore: auto version bump [bot]

* remove a comment

---------

Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
2024-08-26 11:15:29 +02:00
Ömer Faruk Irmak
233a6adc15
feat: async ccc checker (#996) 2024-08-23 11:04:12 +03:00
colin
9de4980851
feat(rollup-verifier): codecv4 (#991)
* feat(rollup-verifier): codecv4

* fix golint

* enhancements

* rename

* rename

* feat: add darwinv2 in genesis config

* bump version

* fix typo

* Update params/config.go

Co-authored-by: georgehao <haohongfan@gmail.com>

* add DarwinV2

* address comments

* move a comment to other places

* small refactors

* chore: auto version bump [bot]

* update da-codec commit

* fix a bug

---------

Co-authored-by: georgehao <haohongfan@gmail.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
2024-08-23 14:50:08 +08:00
colin
0ed16b0739
feat: add darwinv2 in genesis config (#993)
* feat: add darwinv2 in genesis config

* bump version

* fix typo

* Update params/config.go

Co-authored-by: georgehao <haohongfan@gmail.com>

---------

Co-authored-by: georgehao <haohongfan@gmail.com>
2024-08-21 18:36:21 +02:00
georgehao
4b85bbcbd8
calculate tx the lifecycle duration (#839)
* feat: add transactions len metrics of block processer

* calculate tx lifecycle median duration

* chore: auto version bump [bot]

* fix

* fix

* fix

* chore: auto version bump [bot]

* address comments

* remove error code

* address comment

* update

* Update core/tx_pool.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* Update core/types/transaction.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* Update core/tx_pool.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* Update core/tx_pool.go

---------

Co-authored-by: georgehao <georgehao@users.noreply.github.com>
Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
2024-08-13 16:45:01 +08:00
Péter Garamvölgyi
dfd4039be7
feat: schedule Darwin hard fork (#963) 2024-08-05 09:13:29 +02:00
Ömer Faruk Irmak
2ba5ea3058
Revert "refactor: reduce number of heap allocations in tracing (#952)" (#959)
This reverts commit b84f4ed6f8.
2024-08-02 21:59:50 +08:00
HAOYUatHZ
ee0410ec10
feat: update L2 base fee formula (#951)
* update `CalcBaseFee`

* update `TestCalcBaseFee`

* update `TestStateProcessorErrors`

* bump version

* update threshold
2024-08-02 10:09:33 +08:00
Ömer Faruk Irmak
b84f4ed6f8
refactor: reduce number of heap allocations in tracing (#952) 2024-08-01 14:52:43 +03:00
Ömer Faruk Irmak
51c7eee1e4
feat(clique): allow shadowforking a clique network (#828) 2024-08-01 12:11:00 +03:00
Ömer Faruk Irmak
9abdd5b9aa
feat: defer txpool reorg until worker fetches txns for the next block (#905) 2024-07-26 10:25:58 +03:00
georgehao
df3713e840
feat(libzkp):unbounded depth serde json (#920)
* feat: add transactions len metrics of block processer

* fix

* format

* chore: auto version bump [bot]

* remove unusd code

---------

Co-authored-by: georgehao <georgehao@users.noreply.github.com>
2024-07-24 11:59:30 +08:00
Péter Garamvölgyi
f2af32d3d5
fix: log Rust trace parsing error (#918)
* fix: log Rust trace parsing error

* fix
2024-07-24 01:47:47 +02:00
HAOYUatHZ
9ee6976fe5
fix(miner,rpc): fix updateSnapshot (#916)
* fix `updateSnapshot`

* fix

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
2024-07-23 22:22:51 +08:00
colin
de0385e7d2
fix(verifier): nil panic due to batch write (#911) 2024-07-20 00:39:28 +08:00
colin
0360eba836
fix(l2geth-verifier): only check last batch of the bundle (#904)
* fix(l2geth-verifier): only check the last batch of each bundle

* refactor function comments

* add more logs to debug

* fix the bug

* Revert "add more logs to debug"

This reverts commit 4befe9fe739275988b4bf34999bd1aad4d7a1d0e.

* tweak

* TestValidateBatchInFinalizeByBundle

* update da-codec dependency

* move rawdb.WriteFinalizedBatchMeta outside the loop

* use batch writer

* change log.Crit to log.Error
2024-07-17 20:01:40 +08:00
Zhang Zhuo
0cecc1986e
refactor(trace): clean outdated fields (#842)
* clean trace: remove ExtraData, disable prestateTracer, collect bytecodes in top level

* fix

* fix

* fix

* fix

* fix

* more cleanup

* more cleanup

* refactor(trace): clean outdated fields

* fix bytecodes in trace

* chore: auto version bump [bot]

* chore: auto version bump [bot]

* use hexutil.Bytes

---------

Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Co-authored-by: omerfirmak <omerfirmak@users.noreply.github.com>
Co-authored-by: lispc <lispc@users.noreply.github.com>
2024-07-15 20:36:00 +08:00
colin
df08f60183
fix(rollup-verifier): decode commitBatchWithBlobProof calldata (#896)
fix(rollup-verifier): decode commitBatchWithBlobProof

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
2024-07-13 00:37:31 +08:00
Péter Garamvölgyi
0b5146bdef
feat(txpool): use GasFeeCapIntCmp to check min fee (#901)
* feat(txpool): use GasFeeCapIntCmp to check min fee

* fix test
2024-07-12 11:56:35 +02:00
HAOYUatHZ
55f70cc6e8
fix(tracing): fix error handling in fillBlockTrace (#890)
* fix(tracing): fix error handling in `fillBlockTrace`

* chore: auto version bump [bot]

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
2024-07-11 18:58:07 +08:00