Commit graph

2428 commits

Author SHA1 Message Date
Arpit Temani
b48b89f852
all: implement milestones (#961)
* Milestone Implementation

* Merge branch 'POS-347' into reciept-e2e-test

* Changes for testing, will be removed after testing

* Debugged the error

* Just for testing purpose

* refactor debug api methods, rename whitelist -> checkpoint

* remove first iteration based vars

* fix linters

* Rewind Changes

* Error changes

* RewindBack function in bor_checkpoint_verifier

* Testcases

* Added the fetch test for milestone and checkpoint

* Debugged the lint changes

* Debugged the lint changes

* Debugged the lint changes

* Debugged the lint changes

* Improved the error in Miner test file

* Improved the error of pointing to the wrong function

* Locking the sprint after the vote has been made on it.

* Adding more logs for testing

* Adding more logs for testing

* Adding more logs for testing

* Implemented the NoAckMilestone fetching mechanism

* Testcases for milestone implementation

* Testing code  for fetchNoAckMilestone and fetchLastNoAckMilestone

* Testing changes

* refactor else-if

* Corrected the number of params in bor_ext.go

* Dummy API for testing

* Defined the GetVoteOnRootHash in interface

* Defined the GetVoteOnRootHash in interface

* Made changes in the web3ext file

* Added the GetVoteOnRootHash in PublicBlockChain API

* Added the GetVoteOnRootHash in filterBackend

* Added the log of Root and RooHash

* Removed the 0x from rootHash

* Just for testing purpose

* "GetVoteOnRootHash" mock implementation

* bor_test.go

* Added the test for milestone implementation

* Added service for fetching milestone by ID

* Improved the comments

* Removed the duplicate code

* use setter for borVerifier

* use setter for borVerifier

* refactor handleNoAckMilestone

* remove code repetition with retry function

* Converged the repetitive code

* after CR

* persistence

* persistence implementation

* feature flag

* Persistence Changes

* cr

* initial

* fix

* fix

* Whitelist Flag

* 1 Add:Included the milestone flag  2.Add:Hardlimit the rewind to maximum of 255 blocks

* Chg:Updated go.mod file

* Remove:Dubai Hardfork code

* Add:checked errors for call functions to the Db, Rmv: Remote Header variable from the IsValidPeer() function

* Fix:Linting issues'

* Add:MilestoneGRPC functions

* Fix:Lint issues

* Fix:Lint issues

* Fix: TestFetchMilestoneFromMockHeimdall

* Fix:Integrations tests

* Add:Test for sprint length and milestone changes

* Add:Functionality to fetch the finalized block

* Chg:Changed default val of TriesInmemory to 1024

* fix:Some functions of heimdallGRPC client

* Restored the GRPC functionality, was commented out for  developing purpose

* Fix:Bor_checkpoint_Verfier function

* Test:Added the chain Rewinding test

* Test:Added the Sprint Length + Milestone merge test

* Add:Implemented the future milestone

* Add:Future milestone changes

* Add:Future milestone changes

* Chg: Voting on endBlockHash rather than rootHash

* Chg: Changed the logic of future milestone from rootHash checking to endBlockHash checking

* Fix:Using endBockHash while verifying the incoming milestone

* Chg:Variable names for better readiblity

* Fix:Testing changes

* Add:metrics for milestone implementation

* Add:Metrics for milestone implementatian

* Fix:Order of statements in a function for better optimization

* Chg:Removed unrequired file

* Fix:new variable intialization

* Add:Comment to increase readiblity

* Fix:Logs

* Chg:Name of GetVoteOnRootHash to GetVoteOnHash

* Fix:Linting issues

* Fixed linting issues

* Rmv: Unnecessary logs and Add:Skip test for long tests

* Fix:Checking current chain with whitelisted milestone or checkpoint in Finalized block function

* Fix:Test

* Fix:Whitelisting of Milestone and Checkpoint process

* Fix: Milestone JSON structure

* Chg:Testcases changes

* Fix:Change from VoteOnRootHash to VoteOnHash

* Fix:Variable name fix

* Fix:Finalized API

* internal/jsre/deps: update web3.js bundle

* Fix:milestone verifier

* Chg:Handling the long future chain import issue

* Fix:Lint issues

* Fix:TestLowDiffLongChain and TestPrunedImportSide tests, used hardcoded value 128 instead of DefaultTriesInMemory value

* Chg:Testcode for producing metrics

* Chg:Milestong polling value to 32 secs

* Add:Testcases

* Add:Implemented the check to fetch the milestoneId from heimdall before locking the fork

* Added GRPC method for FetchMilestoneID

* Fix:lint issue

* Fix:lint issue

* Skiped out the tests which were mainly used to produce the supporting data

* remove vcs build when running snyk

* Add:Improved the logs and comments

* fix linters

* Skipped some test as they are panic due to timeout issue in github

* Chg:Variable name LockerSprintNumber to LockedMilestoneNumber for better readablity and clarity

* Chg:Conflicting variable names in milestone test file

* Chg:Conflicting function names in milestone test file

* fix : minor fix in TestInsertingSpanSizeBlocks

* Fix:Mocking issue in TestInsertingSpanSizeBlocks

* Fix:GRPC Polyproto Version

* eth/downloader: skip peer drop due to whitelisting err

* eth, tests/bor: bug fixes and minor refactor

* Add:Implemented the milestone related functions in the HeimdallApp

* Fix:Lint Errors & Remove:Redundant Code

* Fix:Testing Errors

* Fix:Bor integeration tests

* Fix:Test errors

* update heimdall client mock files

* remove unused arguments

* remove redundant code

* Chg:Changed the milestone polling intervals

* Add: added block finality from whitelisted checkpoint

* skip future chain validation

* Add:confirmation check of 16 blocks over the end block while voting for the milestone in GetVoteHash() function

* Chg:Included endBlockNum in UnlockMutex function

* Add:Property based test for milestone

* Fix:Opening the lock while processing future milestone

* Add:Property based test for futureMilestone

* Defined the value of TempTriesInMemory

* Fixed the finalized api

* Fixed lint issues

* eth: add logs while fetching and rewinding

* fix linters: use default returns instead of recursive calls

* Fix:Milestone intergration test

* Add:GetVoteHash fn in mock backend

* tests/bor: fix mock span

* tests/bor: remove t.Parallel()

* use bor namespace in ethclient, fix mock function

---------

Co-authored-by: Vaibhav Jindal <vaibhavjindal29@gmail.com>
Co-authored-by: VaibhavJindal <74560896+VAIBHAVJINDAL3012@users.noreply.github.com>
Co-authored-by: Manav Darji <manavdarji.india@gmail.com>
Co-authored-by: Evgeny Danienko <6655321@bk.ru>
Co-authored-by: Shivam Sharma <shivam691999@gmail.com>
Co-authored-by: Anshal Shukla <shukla.anshal85@gmail.com>
2023-08-28 18:42:21 +05:30
Manav Darji
9eb9bfe181 core/txpool: convert lock acquire log to debug 2023-08-24 11:42:05 +05:30
Shivam Sharma
750437b93e fix : TxDependency 2023-07-28 18:02:53 +05:30
Shivam Sharma
6528e4500b fix : lint 2023-07-24 14:44:50 +05:30
Shivam Sharma
811c90f549 Merge branch 'develop' into mardizzone/upstream-merge 2023-07-24 14:19:30 +05:30
Shivam Sharma
973f11647a rm: t.parallel from testQueueTimeLimiting tests 2023-07-23 15:27:01 +05:30
Shivam Sharma
c48743ad0f fix : deadlocks 2023-07-21 18:46:35 +05:30
Shivam Sharma
706af9e650 fix : TestGraphQLConcurrentResolvers 2023-07-18 18:15:06 +05:30
Raneet Debnath
964faf2883
core: restore AddFeeTransferLog post miner tipping 2023-07-18 13:52:36 +05:30
Shivam Sharma
54acb92cb4 fix : test-integration 2023-07-17 16:39:12 +08:00
Raneet Debnath
0f32302313
common,core,miner: fix goleaks,duplicate init and inconsistent mutex (un)locks 2023-07-13 11:23:20 +08:00
Raneet Debnath
60b85cf088
core,eth/tracers: fix TestPrestateWithDiffModeTracer 2023-07-06 15:51:52 +05:30
Jerry
46882e8247
Fix header encoding test 2023-07-05 13:22:45 -07:00
Shivam Sharma
a454c46c79 adding balance send to burntcontract back 2023-07-05 18:10:13 +05:30
Shivam Sharma
25be12715f rm : multiple coinbase balance 2023-07-05 16:36:30 +05:30
Shivam Sharma
e2292bfc3e fix : TestTxIndexer 2023-07-04 20:30:32 +05:30
Raneet Debnath
b605c3848e
core,eth: fix TestDeduplication, TestSyncAccountPerformance, TestTraceTransaction 2023-07-04 19:16:19 +05:30
Shivam Sharma
616e33f290 fix : TestBeaconSync66 2023-07-04 16:50:05 +05:30
Shivam Sharma
2ad1e0f7e9 fix : TestTransactionIndices, testBeaconSync 2023-07-04 13:41:04 +05:30
Raneet Debnath
2b06029fb8
core,eth,miner: fix initial test cases (#922) 2023-07-04 10:43:28 +05:30
Shivam Sharma
6d4e60045a fix : freezer, TestStateProcessorErrors 2023-07-03 17:11:56 +05:30
Shivam Sharma
392bebdb05 fix : testcase : config, addTxWithChain, burnAmount 2023-06-26 14:07:31 +05:30
Shivam Sharma
64486d0a82 fix : runtime testcases 2023-06-26 12:54:08 +05:30
marcello33
43e114beda dev: fix: tests failing due to t.Parallel 2023-06-21 15:03:16 +02:00
marcello33
ba61cfa2e1 dev: fix: t.Parallel called multiple times 2023-06-21 10:54:47 +02:00
marcello33
99693ef56c dev: fix: all remaining lint issues 2023-06-19 11:39:59 +02:00
marcello33
f3ffacf2d7 dev: fix: most of wsl lint issues 2023-06-15 15:48:26 +02:00
marcello33
82f33b22f5 dev: fix: more errcheck lint issues 2023-06-15 15:31:07 +02:00
marcello33
6223765aab dev: fix: more wsl lint issues 2023-06-15 15:10:57 +02:00
marcello33
131d7b221f dev: fix: solve more lint issues 2023-06-15 14:54:08 +02:00
marcello33
218917076c dev: fix: more wsl lint issues 2023-06-15 13:06:10 +02:00
marcello33
3af5e435c7 dev: fix: some wsl lint issues 2023-06-15 12:27:20 +02:00
marcello33
2c87219c80 dev: fix: bodyclose lint issues 2023-06-15 10:11:23 +02:00
marcello33
79ff0c17e1 dev: fix: error related lint issues 2023-06-14 17:21:52 +02:00
marcello33
6850ca4d2d dev: fix: govet lint errors 2023-06-14 17:08:14 +02:00
marcello33
4307e68288 dev: fix: http related and nilnil lint errors 2023-06-14 16:58:04 +02:00
marcello33
631efbe675 dev: fix: thelper and tparallel lint 2023-06-14 16:29:26 +02:00
marcello33
df106e64df dev: fix: CreateConsensusEngine for new ethereum objects 2023-06-13 15:11:08 +02:00
marcello33
dda0d1163f dev: chg: solve some TODOs 2023-06-13 13:11:25 +02:00
marcello33
b5571e97fb dev: chg: further fixes merging develop into upstream-merge 2023-06-13 13:01:18 +02:00
marcello33
8562597c6c dev: chg: regression changes after develop is merged into upstream-merge 2023-06-13 12:50:48 +02:00
marcello33
1c106dc251 dev: add: merge develop in upstream-merge 2023-06-13 12:37:20 +02:00
marcello33
81c3f1e035 dev: chg: txpool_test regression changes after merge 2023-06-13 10:01:12 +02:00
Matthieu Vachon
891ec7fef6
Use big.Int#Set instead of big.Int#SetBytes when possible (#896)
There is no reason to make the bytes transformation and back to big int to assign a big int to another one.

The `Set` method should be used instead.
2023-06-13 12:02:57 +05:30
marcello33
d3f6da90e1 dev: chg: more regression changes for bor after merge 2023-06-12 19:35:40 +02:00
marcello33
162af07d38 dev: chg: regression changes for bor after merge 2023-06-12 16:46:03 +02:00
marcello33
a043ec6d62 dev: add: merge upstream 2023-06-09 14:34:30 +02:00
Jerry
f96c668baf
Disable reverted tx optimization in block-stm validation (#891)
A reverted transaction, X, can incorrectly write to a slot, which might be read by another transaction, Y. If we skip checking states written by X, then Y might end up with reading the wrong value and we won't be able to detect this error.
2023-06-06 21:36:36 -07:00
Jerry
3d30c341c4
Keep nonce and balance in write list even if the transaction is reverted (#889)
An address's nonce and balance will get updated even if its transaction is reverted. Therefore, we need to keep balance and nonce in write list in order to check the transaction's validity in parallel execution.
2023-06-05 22:10:48 -07:00
Jerry
f2c48fed0b
Remove dependency when a transaction is reverted
If a transaction is reverted, its write records should be excluded from
dependency calculation.
2023-05-11 09:09:33 -07:00