Commit graph

26 commits

Author SHA1 Message Date
Daniel Liu
7fd5927081
accounts/scwallet: fix panic in decryptAPDU #33606 (#1982)
Validate ciphertext length in decryptAPDU, preventing runtime panics on
invalid input.

Co-authored-by: DeFi Junkie <deffie.jnkiee@gmail.com>
2026-01-29 11:25:27 +05:30
Daniel Liu
8c4863a567
accounts/scwallet: fixes nil pointer dereference in scwallet #32186 (#1429)
Fixes #32181

Signed-off-by: kapil <kapilsareen584@gmail.com>
Co-authored-by: Kapil Sareen <kapilsareen584@gmail.com>
2025-09-06 17:03:04 +08:00
Daniel Liu
d2e00672c5 accounts: avoid duplicate regex compilation (#29943)
* fix: Optimize regular initialization

* modify var name

* variable change to private types
2025-01-24 16:54:12 +08:00
Daniel Liu
ef71887d7a accounts, cmd/geth, core: close opened files (#29598)
* fix: open file used up but not closed

* feat: more same case

* feat: accept conversation
2025-01-24 16:54:12 +08:00
Daniel Liu
2b60816af1 accounts/scwallet: remove references to deprecated elliptic package (#28946) 2025-01-24 16:54:12 +08:00
Daniel Liu
2dfb1cf7d3 accounts: fix typos (#28881) 2025-01-24 16:54:12 +08:00
Daniel Liu
e78abe0e44 accounts/scwallet: replace strings.SplitN(arg, sep, 2) with strings.Cut(arg, sep) (#28446) 2025-01-24 16:54:12 +08:00
Daniel Liu
382855b191 accounts, cmd: fix typos (#28300) 2025-01-24 16:54:12 +08:00
Daniel Liu
d4bf06d689 accounts: replace noarg fmt.Errorf with errors.New (#27331)
* accounts: replace noarg fmt.Errorf with errors.New

Signed-off-by: jsvisa <delweng@gmail.com>

* accounts: go autoimport

Signed-off-by: jsvisa <delweng@gmail.com>

---------

Signed-off-by: jsvisa <delweng@gmail.com>
2025-01-24 16:54:12 +08:00
Daniel Liu
4292979685 accounts/scwallet: fix keycard data signing error (#25331)
accounts/scwallet: fix keycard data signing
2025-01-24 16:54:11 +08:00
Daniel Liu
b62913b54f accounts/scwallet: change format 0x%x to %#x (#25221) 2025-01-24 16:54:11 +08:00
Daniel Liu
9e82b201c7 accouts/scwallet: typo fix (#24207) 2025-01-24 16:18:30 +08:00
Daniel Liu
146ea8ba78 accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (#21502) 2025-01-24 16:18:30 +08:00
Daniel Liu
4e23f7b607 accounts/scwallet: update documentation (#22242) 2025-01-24 16:18:30 +08:00
Daniel Liu
f8c67edb64 accounts/scwallet: use go-ethereum crypto instead of go-ecdh (#22212)
* accounts/scwallet: use go-ethereum crypto instead of go-ecdh

github.com/wsddn/go-ecdh is a wrapper package for ECDH functionality
with any elliptic curve.

Since 'generic' ECDH is not required in accounts/scwallet (the curve is
always secp256k1), we can just use the standard library functionality
and our own crypto libraries to perform ECDH and save a dependency.

* Update accounts/scwallet/securechannel.go

Co-authored-by: Guillaume Ballet <gballet@gmail.com>

* Use the correct key

Co-authored-by: Guillaume Ballet <gballet@gmail.com>
2025-01-24 16:18:30 +08:00
Daniel Liu
5b48621c36 accouts, core: fix some comments (#21617) 2025-01-24 16:18:30 +08:00
Daniel Liu
afc814b00d accounts: fix typos in comments (#21118) 2025-01-24 16:18:29 +08:00
Daniel Liu
601d1c80ea accounts/scwallet: fix unnecessary use of fmt.Sprint 2025-01-24 16:18:29 +08:00
Daniel Liu
db708e7697 accounts/scwallet: fix staticcheck warnings (#20370) 2025-01-24 16:18:29 +08:00
Daniel Liu
fb35c54280 accounts/scwallet: change sc url scheme to keycard (#19632) 2025-01-24 16:18:29 +08:00
Daniel Liu
f80a00b6fa accounts/scwallet: display PUK retry count, validate PIN/PUK length (#19524) 2025-01-24 16:18:29 +08:00
Daniel Liu
7c8707f03e accounts, p2p: make CGO_ENABLED=0 build again (#19593) 2025-01-24 16:18:29 +08:00
Daniel Liu
44b6b14685 accounts/scwallet: fix card pairing instruction message (#19436) 2025-01-24 16:18:29 +08:00
Daniel Liu
194a77505f accounts: switch Ledger derivation path to canonical one (#19438) 2025-01-24 16:18:29 +08:00
Daniel Liu
508ae8f155 accounts/scwallet: Update README for v2.2.1 support (#19425)
Update the app download link to the latest version, as requested in #19418
2025-01-24 16:18:29 +08:00
Daniel Liu
2999bea17f accounts: smartcard wallet without the dependency on libpcsclite (#19273) 2025-01-24 16:18:29 +08:00