mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-02-27 16:17:22 +00:00
684f0db4a2
This pull request introduces a queue for legacy sidecar conversion to handle transactions that persist after the Osaka fork. Simply dropping these transactions would significantly harm the user experience. To balance usability with system complexity, we have introduced a conversion time window of two hours post Osaka fork. During this period, the system will accept legacy blob transactions and convert them in a background process. After the window, all legacy transactions will be rejected. Notably, all the blob transactions will be validated statically before the conversion, and also all conversion are performed in a single thread, minimize the risk of being DoS. We believe this two hour window provides sufficient time to process in-flight legacy transactions and allows submitters to migrate to the new format. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
101 lines
3.3 KiB
Go
101 lines
3.3 KiB
Go
// Copyright 2025 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package blobpool
|
|
|
|
import (
|
|
"crypto/ecdsa"
|
|
"crypto/sha256"
|
|
"testing"
|
|
|
|
"github.com/ethereum/go-ethereum/common"
|
|
"github.com/ethereum/go-ethereum/core/types"
|
|
"github.com/ethereum/go-ethereum/crypto"
|
|
"github.com/ethereum/go-ethereum/crypto/kzg4844"
|
|
"github.com/ethereum/go-ethereum/params"
|
|
"github.com/holiman/uint256"
|
|
)
|
|
|
|
// createV1BlobTx creates a blob transaction with version 1 sidecar for testing.
|
|
func createV1BlobTx(nonce uint64, key *ecdsa.PrivateKey) *types.Transaction {
|
|
blob := &kzg4844.Blob{byte(nonce)}
|
|
commitment, _ := kzg4844.BlobToCommitment(blob)
|
|
cellProofs, _ := kzg4844.ComputeCellProofs(blob)
|
|
|
|
blobtx := &types.BlobTx{
|
|
ChainID: uint256.MustFromBig(params.MainnetChainConfig.ChainID),
|
|
Nonce: nonce,
|
|
GasTipCap: uint256.NewInt(1),
|
|
GasFeeCap: uint256.NewInt(1000),
|
|
Gas: 21000,
|
|
BlobFeeCap: uint256.NewInt(100),
|
|
BlobHashes: []common.Hash{kzg4844.CalcBlobHashV1(sha256.New(), &commitment)},
|
|
Value: uint256.NewInt(100),
|
|
Sidecar: types.NewBlobTxSidecar(types.BlobSidecarVersion1, []kzg4844.Blob{*blob}, []kzg4844.Commitment{commitment}, cellProofs),
|
|
}
|
|
return types.MustSignNewTx(key, types.LatestSigner(params.MainnetChainConfig), blobtx)
|
|
}
|
|
|
|
func TestConversionQueueBasic(t *testing.T) {
|
|
queue := newConversionQueue()
|
|
defer queue.close()
|
|
|
|
key, _ := crypto.GenerateKey()
|
|
tx := makeTx(0, 1, 1, 1, key)
|
|
if err := queue.convert(tx); err != nil {
|
|
t.Fatalf("Expected successful conversion, got error: %v", err)
|
|
}
|
|
if tx.BlobTxSidecar().Version != types.BlobSidecarVersion1 {
|
|
t.Errorf("Expected sidecar version to be %d, got %d", types.BlobSidecarVersion1, tx.BlobTxSidecar().Version)
|
|
}
|
|
}
|
|
|
|
func TestConversionQueueV1BlobTx(t *testing.T) {
|
|
queue := newConversionQueue()
|
|
defer queue.close()
|
|
|
|
key, _ := crypto.GenerateKey()
|
|
tx := createV1BlobTx(0, key)
|
|
version := tx.BlobTxSidecar().Version
|
|
|
|
err := queue.convert(tx)
|
|
if err != nil {
|
|
t.Fatalf("Expected successful conversion, got error: %v", err)
|
|
}
|
|
if tx.BlobTxSidecar().Version != version {
|
|
t.Errorf("Expected sidecar version to remain %d, got %d", version, tx.BlobTxSidecar().Version)
|
|
}
|
|
}
|
|
|
|
func TestConversionQueueClosed(t *testing.T) {
|
|
queue := newConversionQueue()
|
|
|
|
// Close the queue first
|
|
queue.close()
|
|
key, _ := crypto.GenerateKey()
|
|
tx := makeTx(0, 1, 1, 1, key)
|
|
|
|
err := queue.convert(tx)
|
|
if err == nil {
|
|
t.Fatal("Expected error when converting on closed queue, got nil")
|
|
}
|
|
}
|
|
|
|
func TestConversionQueueDoubleClose(t *testing.T) {
|
|
queue := newConversionQueue()
|
|
queue.close()
|
|
queue.close() // Should not panic
|
|
}
|