mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-02-26 07:37:20 +00:00
Looks like (in some very EVM specific tests) we spent a lot of time
resizing memory. If the underlying array is big enough, we can speed it
up a bit by simply slicing the memory.
goos: linux
goarch: amd64
pkg: github.com/ethereum/go-ethereum/core/vm
cpu: Intel(R) Core(TM) Ultra 7 155U
│ /tmp/old.txt │ /tmp/new.txt │
│ sec/op │ sec/op vs base │
Resize-14 6.145n ± 9% 1.854n ± 14% -69.83% (p=0.000 n=10)
│ /tmp/old.txt │ /tmp/new.txt │
│ B/op │ B/op vs base │
Resize-14 5.000 ± 0% 5.000 ± 0% ~ (p=1.000 n=10)
│ /tmp/old.txt │ /tmp/new.txt │
│ allocs/op │ allocs/op vs base │
Resize-14 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
From the blocktest benchmark:
620ms 10.93s (flat, cum) 9.92% of Total
. . 80:func (m *Memory) Resize(size uint64) {
30ms 60ms 81: if uint64(m.Len()) < size {
590ms 10.87s 82: m.store = append(m.store, make([]byte, size-uint64(m.Len()))...)
. . 83: }
. . 84:}
---------
Co-authored-by: Felix Lange <fjl@twurst.com>
132 lines
3.7 KiB
Go
132 lines
3.7 KiB
Go
// Copyright 2015 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package vm
|
|
|
|
import (
|
|
"sync"
|
|
|
|
"github.com/holiman/uint256"
|
|
)
|
|
|
|
var memoryPool = sync.Pool{
|
|
New: func() any {
|
|
return &Memory{}
|
|
},
|
|
}
|
|
|
|
// Memory implements a simple memory model for the ethereum virtual machine.
|
|
type Memory struct {
|
|
store []byte
|
|
lastGasCost uint64
|
|
}
|
|
|
|
// NewMemory returns a new memory model.
|
|
func NewMemory() *Memory {
|
|
return memoryPool.Get().(*Memory)
|
|
}
|
|
|
|
// Free returns the memory to the pool.
|
|
func (m *Memory) Free() {
|
|
// To reduce peak allocation, return only smaller memory instances to the pool.
|
|
const maxBufferSize = 16 << 10
|
|
if cap(m.store) <= maxBufferSize {
|
|
clear(m.store)
|
|
m.store = m.store[:0]
|
|
m.lastGasCost = 0
|
|
memoryPool.Put(m)
|
|
}
|
|
}
|
|
|
|
// Set sets offset + size to value
|
|
func (m *Memory) Set(offset, size uint64, value []byte) {
|
|
// It's possible the offset is greater than 0 and size equals 0. This is because
|
|
// the calcMemSize (common.go) could potentially return 0 when size is zero (NO-OP)
|
|
if size > 0 {
|
|
// length of store may never be less than offset + size.
|
|
// The store should be resized PRIOR to setting the memory
|
|
if offset+size > uint64(len(m.store)) {
|
|
panic("invalid memory: store empty")
|
|
}
|
|
copy(m.store[offset:offset+size], value)
|
|
}
|
|
}
|
|
|
|
// Set32 sets the 32 bytes starting at offset to the value of val, left-padded with zeroes to
|
|
// 32 bytes.
|
|
func (m *Memory) Set32(offset uint64, val *uint256.Int) {
|
|
// length of store may never be less than offset + size.
|
|
// The store should be resized PRIOR to setting the memory
|
|
if offset+32 > uint64(len(m.store)) {
|
|
panic("invalid memory: store empty")
|
|
}
|
|
// Fill in relevant bits
|
|
val.PutUint256(m.store[offset:])
|
|
}
|
|
|
|
// Resize grows the memory to the requested size.
|
|
func (m *Memory) Resize(size uint64) {
|
|
if uint64(len(m.store)) < size {
|
|
if uint64(cap(m.store)) >= size {
|
|
m.store = m.store[:size]
|
|
} else {
|
|
m.store = append(m.store, make([]byte, size-uint64(len(m.store)))...)
|
|
}
|
|
}
|
|
}
|
|
|
|
// GetCopy returns offset + size as a new slice
|
|
func (m *Memory) GetCopy(offset, size uint64) (cpy []byte) {
|
|
if size == 0 {
|
|
return nil
|
|
}
|
|
|
|
// memory is always resized before being accessed, no need to check bounds
|
|
cpy = make([]byte, size)
|
|
copy(cpy, m.store[offset:offset+size])
|
|
return
|
|
}
|
|
|
|
// GetPtr returns the offset + size
|
|
func (m *Memory) GetPtr(offset, size uint64) []byte {
|
|
if size == 0 {
|
|
return nil
|
|
}
|
|
|
|
// memory is always resized before being accessed, no need to check bounds
|
|
return m.store[offset : offset+size]
|
|
}
|
|
|
|
// Len returns the length of the backing slice
|
|
func (m *Memory) Len() int {
|
|
return len(m.store)
|
|
}
|
|
|
|
// Data returns the backing slice
|
|
func (m *Memory) Data() []byte {
|
|
return m.store
|
|
}
|
|
|
|
// Copy copies data from the src position slice into the dst position.
|
|
// The source and destination may overlap.
|
|
// OBS: This operation assumes that any necessary memory expansion has already been performed,
|
|
// and this method may panic otherwise.
|
|
func (m *Memory) Copy(dst, src, len uint64) {
|
|
if len == 0 {
|
|
return
|
|
}
|
|
copy(m.store[dst:], m.store[src:src+len])
|
|
}
|