Martin HS 057667151b core/types, trie: reduce allocations in derivesha (#30747) ... Alternative to #30746, potential follow-up to #30743 . This PR makes the stacktrie always copy incoming value buffers, and reuse them internally. Improvement in #30743: ``` goos: linux goarch: amd64 pkg: github.com/ethereum/go-ethereum/core/types cpu: 12th Gen Intel(R) Core(TM) i7-1270P │ derivesha.1 │ derivesha.2 │ │ sec/op │ sec/op vs base │ DeriveSha200/stack_trie-8 477.8µ ± 2% 430.0µ ± 12% -10.00% (p=0.000 n=10) │ derivesha.1 │ derivesha.2 │ │ B/op │ B/op vs base │ DeriveSha200/stack_trie-8 45.17Ki ± 0% 25.65Ki ± 0% -43.21% (p=0.000 n=10) │ derivesha.1 │ derivesha.2 │ │ allocs/op │ allocs/op vs base │ DeriveSha200/stack_trie-8 1259.0 ± 0% 232.0 ± 0% -81.57% (p=0.000 n=10) ``` This PR further enhances that: ``` goos: linux goarch: amd64 pkg: github.com/ethereum/go-ethereum/core/types cpu: 12th Gen Intel(R) Core(TM) i7-1270P │ derivesha.2 │ derivesha.3 │ │ sec/op │ sec/op vs base │ DeriveSha200/stack_trie-8 430.0µ ± 12% 423.6µ ± 13% ~ (p=0.739 n=10) │ derivesha.2 │ derivesha.3 │ │ B/op │ B/op vs base │ DeriveSha200/stack_trie-8 25.654Ki ± 0% 4.960Ki ± 0% -80.67% (p=0.000 n=10) │ derivesha.2 │ derivesha.3 │ │ allocs/op │ allocs/op vs base │ DeriveSha200/stack_trie-8 232.00 ± 0% 37.00 ± 0% -84.05% (p=0.000 n=10) ``` So the total derivesha-improvement over *both PRS* is: ``` goos: linux goarch: amd64 pkg: github.com/ethereum/go-ethereum/core/types cpu: 12th Gen Intel(R) Core(TM) i7-1270P │ derivesha.1 │ derivesha.3 │ │ sec/op │ sec/op vs base │ DeriveSha200/stack_trie-8 477.8µ ± 2% 423.6µ ± 13% -11.33% (p=0.015 n=10) │ derivesha.1 │ derivesha.3 │ │ B/op │ B/op vs base │ DeriveSha200/stack_trie-8 45.171Ki ± 0% 4.960Ki ± 0% -89.02% (p=0.000 n=10) │ derivesha.1 │ derivesha.3 │ │ allocs/op │ allocs/op vs base │ DeriveSha200/stack_trie-8 1259.00 ± 0% 37.00 ± 0% -97.06% (p=0.000 n=10) ``` Since this PR always copies the incoming value, it adds a little bit of a penalty on the previous insert-benchmark, which copied nothing (always passed the same empty slice as input) : ``` goos: linux goarch: amd64 pkg: github.com/ethereum/go-ethereum/trie cpu: 12th Gen Intel(R) Core(TM) i7-1270P │ stacktrie.7 │ stacktrie.10 │ │ sec/op │ sec/op vs base │ Insert100K-8 88.21m ± 34% 92.37m ± 31% ~ (p=0.280 n=10) │ stacktrie.7 │ stacktrie.10 │ │ B/op │ B/op vs base │ Insert100K-8 3.424Ki ± 3% 4.581Ki ± 3% +33.80% (p=0.000 n=10) │ stacktrie.7 │ stacktrie.10 │ │ allocs/op │ allocs/op vs base │ Insert100K-8 22.00 ± 5% 26.00 ± 4% +18.18% (p=0.000 n=10) ``` --------- Co-authored-by: Gary Rong <garyrong0905@gmail.com> Co-authored-by: Felix Lange <fjl@twurst.com>		2025-10-01 10:05:49 +02:00
..
bintrie	trie/bintrie: add eip7864 binary trees and run its tests (#32365)	2025-09-01 21:06:51 +08:00
trienode	cmd, core, eth, triedb/pathdb: track node origins in the path database (#32418)	2025-09-05 10:37:05 +08:00
utils	all: update license comments and AUTHORS (#31133)	2025-02-05 23:01:17 +01:00
bytepool.go	core/types, trie: reduce allocations in derivesha (#30747)	2025-10-01 10:05:49 +02:00
committer.go	trie/bintrie: add eip7864 binary trees and run its tests (#32365)	2025-09-01 21:06:51 +08:00
database_test.go	trie: no need to store preimage if not enabled (#32012)	2025-06-13 15:04:24 +08:00
encoding.go	trie: reduce allocations in stacktrie (#30743)	2025-01-23 10:17:12 +01:00
encoding_test.go	trie: reduce allocs in recHash (#27770)	2023-08-18 22:41:19 +02:00
errors.go	all: fix various typos (#29600)	2024-04-23 13:09:42 +03:00
hasher.go	trie: reduce the memory allocation in trie hashing (#31902)	2025-08-01 10:23:23 +08:00
iterator.go	trie: add sub-trie iterator support (#32520)	2025-09-17 22:07:02 +08:00
iterator_test.go	trie: align AllFFPrefix test assertion and message (#32719)	2025-09-24 10:36:56 +08:00
list_hasher.go	core/types, trie: reduce allocations in derivesha (#30747)	2025-10-01 10:05:49 +02:00
node.go	trie: reduce the memory allocation in trie hashing (#31902)	2025-08-01 10:23:23 +08:00
node_enc.go	trie: reduce the memory allocation in trie hashing (#31902)	2025-08-01 10:23:23 +08:00
node_test.go	trie: improve node rlp decoding performance (#25357)	2022-08-19 00:39:47 +02:00
proof.go	trie/bintrie: add eip7864 binary trees and run its tests (#32365)	2025-09-01 21:06:51 +08:00
proof_test.go	trie: fix TestOneElementProof expected value message (#32738)	2025-09-24 18:57:01 -06:00
secure_trie.go	core, miner, trie: add metrics tracking state trie depth (#32388)	2025-08-22 22:09:14 +08:00
secure_trie_test.go	core/state, eth/protocols, trie, triedb/pathdb: remove unused error from trie Commit (#29869)	2024-06-12 12:23:16 +03:00
stacktrie.go	core/types, trie: reduce allocations in derivesha (#30747)	2025-10-01 10:05:49 +02:00
stacktrie_fuzzer_test.go	trie: do not expect ordering in stacktrie during fuzzing (#31170)	2025-02-18 10:48:42 +08:00
stacktrie_test.go	trie: reduce allocations in stacktrie (#30743)	2025-01-23 10:17:12 +01:00
sync.go	all: create global hasher pool (#31769)	2025-05-09 13:52:40 +08:00
sync_test.go	core, trie, triedb: minor changes from snapshot integration (#30599)	2024-10-18 17:06:31 +02:00
tracer.go	trie/bintrie: add eip7864 binary trees and run its tests (#32365)	2025-09-01 21:06:51 +08:00
tracer_test.go	trie, core/state: introduce trie Prefetch for optimizing preload (#32134)	2025-08-20 21:45:27 +08:00
transition.go	core,trie: fix typo in TransitionTrie (#32491)	2025-08-25 09:29:58 +02:00
trie.go	core/types, trie: reduce allocations in derivesha (#30747)	2025-10-01 10:05:49 +02:00
trie_id.go	all: update license comments and AUTHORS (#31133)	2025-02-05 23:01:17 +01:00
trie_reader.go	trie/bintrie: add eip7864 binary trees and run its tests (#32365)	2025-09-01 21:06:51 +08:00
trie_test.go	trie: fix error message in test (#32772)	2025-09-29 12:23:43 +02:00
verkle.go	trie/bintrie: add eip7864 binary trees and run its tests (#32365)	2025-09-01 21:06:51 +08:00
verkle_test.go	trie: correct error messages for UpdateStorage operations (#32746)	2025-09-26 07:47:58 -06:00