mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-05-24 08:49:29 +00:00
eth_syncing currently returns false as soon as the local downloader
believes the chain to be done. On a freshly started node this happens
before the consensus client has talked to it: the persisted head loads
into memory, no CL handshake has occurred, the downloader sees nothing
to do, Progress.Done() is true, eth_syncing reports synced.
That is wrong from an operator perspective. Load balancers (HAProxy,
NGINX), L2 supervisors and multi-node setups commonly gate routing on
eth_syncing. They start sending live traffic to a node that has not
actually learned about any new head yet, which surfaces as missing
state, stale reads, and unhealthy upstreams.
Maintainer-endorsed direction in the issue thread: "default geth to
'syncing' on startup and only switch to 'synced' once we learn about
a new block".
Implement that with a sticky atomic.Bool on *Ethereum, set the first
time the consensus layer drives the node via the Engine API
(ForkchoiceUpdated or NewPayload), and consulted from eth_syncing.
- eth/backend.go: add Ethereum.clContacted with
MarkConsensusContacted/ConsensusContacted helpers
- eth/catalyst/api.go: call MarkConsensusContacted at the same point
where lastForkchoiceUpdate / lastNewPayloadUpdate are stamped, so
the gate flips on every CL message regardless of the response
status (handshake recorded even when we reply STATUS_SYNCING)
- internal/ethapi/backend.go: add ConsensusContacted() to the Backend
interface and to the two test mocks (api_test.go testBackend,
transaction_args_test.go backendMock; both default to true so
existing tests keep their original semantics)
- eth/api_backend.go: implement ConsensusContacted on EthAPIBackend
- internal/ethapi/api.go: in EthereumAPI.Syncing, only short-circuit
to "false" when both progress.Done() AND ConsensusContacted() are
true; otherwise return the progress map as during an active sync
Adds dedicated tests in internal/ethapi/syncing_test.go covering:
- the new gate (Done but no CL contact -> truthy progress)
- normal post-handshake behavior (Done + CL contact -> false)
- active-sync behavior is unchanged regardless of the gate
Refs #33687.
133 lines
5.9 KiB
Go
133 lines
5.9 KiB
Go
// Copyright 2015 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
// Package ethapi implements the general Ethereum API functions.
|
|
package ethapi
|
|
|
|
import (
|
|
"context"
|
|
"math/big"
|
|
"time"
|
|
|
|
"github.com/ethereum/go-ethereum"
|
|
"github.com/ethereum/go-ethereum/accounts"
|
|
"github.com/ethereum/go-ethereum/common"
|
|
"github.com/ethereum/go-ethereum/consensus"
|
|
"github.com/ethereum/go-ethereum/core"
|
|
"github.com/ethereum/go-ethereum/core/filtermaps"
|
|
"github.com/ethereum/go-ethereum/core/state"
|
|
"github.com/ethereum/go-ethereum/core/types"
|
|
"github.com/ethereum/go-ethereum/core/vm"
|
|
"github.com/ethereum/go-ethereum/ethdb"
|
|
"github.com/ethereum/go-ethereum/event"
|
|
"github.com/ethereum/go-ethereum/params"
|
|
"github.com/ethereum/go-ethereum/rpc"
|
|
)
|
|
|
|
// Backend interface provides the common API services (that are provided by
|
|
// both full and light clients) with access to necessary functions.
|
|
type Backend interface {
|
|
// General Ethereum API
|
|
SyncProgress(ctx context.Context) ethereum.SyncProgress
|
|
// ConsensusContacted reports whether the consensus layer has driven this
|
|
// node via the Engine API at least once since process start. eth_syncing
|
|
// uses it to avoid reporting "synced" before any CL handshake has happened.
|
|
ConsensusContacted() bool
|
|
|
|
SuggestGasTipCap(ctx context.Context) (*big.Int, error)
|
|
FeeHistory(ctx context.Context, blockCount uint64, lastBlock rpc.BlockNumber, rewardPercentiles []float64) (*big.Int, [][]*big.Int, []*big.Int, []float64, []*big.Int, []float64, error)
|
|
BlobBaseFee(ctx context.Context) *big.Int
|
|
ChainDb() ethdb.Database
|
|
AccountManager() *accounts.Manager
|
|
ExtRPCEnabled() bool
|
|
RPCGasCap() uint64 // global gas cap for eth_call over rpc: DoS protection
|
|
RPCEVMTimeout() time.Duration // global timeout for eth_call over rpc: DoS protection
|
|
RPCTxFeeCap() float64 // global tx fee cap for all transaction related APIs
|
|
UnprotectedAllowed() bool // allows only for EIP155 transactions.
|
|
RPCTxSyncDefaultTimeout() time.Duration
|
|
RPCTxSyncMaxTimeout() time.Duration
|
|
|
|
// Blockchain API
|
|
SetHead(number uint64)
|
|
HeaderByNumber(ctx context.Context, number rpc.BlockNumber) (*types.Header, error)
|
|
HeaderByHash(ctx context.Context, hash common.Hash) (*types.Header, error)
|
|
HeaderByNumberOrHash(ctx context.Context, blockNrOrHash rpc.BlockNumberOrHash) (*types.Header, error)
|
|
CurrentHeader() *types.Header
|
|
CurrentBlock() *types.Header
|
|
BlockByNumber(ctx context.Context, number rpc.BlockNumber) (*types.Block, error)
|
|
BlockByHash(ctx context.Context, hash common.Hash) (*types.Block, error)
|
|
BlockByNumberOrHash(ctx context.Context, blockNrOrHash rpc.BlockNumberOrHash) (*types.Block, error)
|
|
StateAndHeaderByNumber(ctx context.Context, number rpc.BlockNumber) (*state.StateDB, *types.Header, error)
|
|
StateAndHeaderByNumberOrHash(ctx context.Context, blockNrOrHash rpc.BlockNumberOrHash) (*state.StateDB, *types.Header, error)
|
|
Pending() (*types.Block, types.Receipts, *state.StateDB)
|
|
GetReceipts(ctx context.Context, hash common.Hash) (types.Receipts, error)
|
|
GetCanonicalReceipt(tx *types.Transaction, blockHash common.Hash, blockNumber, blockIndex uint64) (*types.Receipt, error)
|
|
GetEVM(ctx context.Context, state *state.StateDB, header *types.Header, vmConfig *vm.Config, blockCtx *vm.BlockContext) *vm.EVM
|
|
SubscribeChainEvent(ch chan<- core.ChainEvent) event.Subscription
|
|
SubscribeChainHeadEvent(ch chan<- core.ChainHeadEvent) event.Subscription
|
|
|
|
// Transaction pool API
|
|
SendTx(ctx context.Context, signedTx *types.Transaction) error
|
|
GetCanonicalTransaction(txHash common.Hash) (bool, *types.Transaction, common.Hash, uint64, uint64)
|
|
TxIndexDone() bool
|
|
GetPoolTransactions() (types.Transactions, error)
|
|
GetPoolTransaction(txHash common.Hash) *types.Transaction
|
|
GetPoolNonce(ctx context.Context, addr common.Address) (uint64, error)
|
|
Stats() (pending int, queued int)
|
|
TxPoolContent() (map[common.Address][]*types.Transaction, map[common.Address][]*types.Transaction)
|
|
TxPoolContentFrom(addr common.Address) ([]*types.Transaction, []*types.Transaction)
|
|
SubscribeNewTxsEvent(chan<- core.NewTxsEvent) event.Subscription
|
|
|
|
ChainConfig() *params.ChainConfig
|
|
Engine() consensus.Engine
|
|
HistoryPruningCutoff() uint64
|
|
|
|
// This is copied from filters.Backend
|
|
// eth/filters needs to be initialized from this backend type, so methods needed by
|
|
// it must also be included here.
|
|
GetBody(ctx context.Context, hash common.Hash, number rpc.BlockNumber) (*types.Body, error)
|
|
GetLogs(ctx context.Context, blockHash common.Hash, number uint64) ([][]*types.Log, error)
|
|
SubscribeRemovedLogsEvent(ch chan<- core.RemovedLogsEvent) event.Subscription
|
|
SubscribeLogsEvent(ch chan<- []*types.Log) event.Subscription
|
|
|
|
CurrentView() *filtermaps.ChainView
|
|
NewMatcherBackend() filtermaps.MatcherBackend
|
|
}
|
|
|
|
func GetAPIs(apiBackend Backend) []rpc.API {
|
|
nonceLock := new(AddrLocker)
|
|
return []rpc.API{
|
|
{
|
|
Namespace: "eth",
|
|
Service: NewEthereumAPI(apiBackend),
|
|
}, {
|
|
Namespace: "eth",
|
|
Service: NewBlockChainAPI(apiBackend),
|
|
}, {
|
|
Namespace: "eth",
|
|
Service: NewTransactionAPI(apiBackend, nonceLock),
|
|
}, {
|
|
Namespace: "txpool",
|
|
Service: NewTxPoolAPI(apiBackend),
|
|
}, {
|
|
Namespace: "debug",
|
|
Service: NewDebugAPI(apiBackend),
|
|
}, {
|
|
Namespace: "eth",
|
|
Service: NewEthereumAccountAPI(apiBackend.AccountManager()),
|
|
},
|
|
}
|
|
}
|