mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-07-27 23:26:44 +00:00
* Milestone Implementation * Merge branch 'POS-347' into reciept-e2e-test * Changes for testing, will be removed after testing * Debugged the error * Just for testing purpose * refactor debug api methods, rename whitelist -> checkpoint * remove first iteration based vars * fix linters * Rewind Changes * Error changes * RewindBack function in bor_checkpoint_verifier * Testcases * Added the fetch test for milestone and checkpoint * Debugged the lint changes * Debugged the lint changes * Debugged the lint changes * Debugged the lint changes * Improved the error in Miner test file * Improved the error of pointing to the wrong function * Locking the sprint after the vote has been made on it. * Adding more logs for testing * Adding more logs for testing * Adding more logs for testing * Implemented the NoAckMilestone fetching mechanism * Testcases for milestone implementation * Testing code for fetchNoAckMilestone and fetchLastNoAckMilestone * Testing changes * refactor else-if * Corrected the number of params in bor_ext.go * Dummy API for testing * Defined the GetVoteOnRootHash in interface * Defined the GetVoteOnRootHash in interface * Made changes in the web3ext file * Added the GetVoteOnRootHash in PublicBlockChain API * Added the GetVoteOnRootHash in filterBackend * Added the log of Root and RooHash * Removed the 0x from rootHash * Just for testing purpose * "GetVoteOnRootHash" mock implementation * bor_test.go * Added the test for milestone implementation * Added service for fetching milestone by ID * Improved the comments * Removed the duplicate code * use setter for borVerifier * use setter for borVerifier * refactor handleNoAckMilestone * remove code repetition with retry function * Converged the repetitive code * after CR * persistence * persistence implementation * feature flag * Persistence Changes * cr * initial * fix * fix * Whitelist Flag * 1 Add:Included the milestone flag 2.Add:Hardlimit the rewind to maximum of 255 blocks * Chg:Updated go.mod file * Remove:Dubai Hardfork code * Add:checked errors for call functions to the Db, Rmv: Remote Header variable from the IsValidPeer() function * Fix:Linting issues' * Add:MilestoneGRPC functions * Fix:Lint issues * Fix:Lint issues * Fix: TestFetchMilestoneFromMockHeimdall * Fix:Integrations tests * Add:Test for sprint length and milestone changes * Add:Functionality to fetch the finalized block * Chg:Changed default val of TriesInmemory to 1024 * fix:Some functions of heimdallGRPC client * Restored the GRPC functionality, was commented out for developing purpose * Fix:Bor_checkpoint_Verfier function * Test:Added the chain Rewinding test * Test:Added the Sprint Length + Milestone merge test * Add:Implemented the future milestone * Add:Future milestone changes * Add:Future milestone changes * Chg: Voting on endBlockHash rather than rootHash * Chg: Changed the logic of future milestone from rootHash checking to endBlockHash checking * Fix:Using endBockHash while verifying the incoming milestone * Chg:Variable names for better readiblity * Fix:Testing changes * Add:metrics for milestone implementation * Add:Metrics for milestone implementatian * Fix:Order of statements in a function for better optimization * Chg:Removed unrequired file * Fix:new variable intialization * Add:Comment to increase readiblity * Fix:Logs * Chg:Name of GetVoteOnRootHash to GetVoteOnHash * Fix:Linting issues * Fixed linting issues * Rmv: Unnecessary logs and Add:Skip test for long tests * Fix:Checking current chain with whitelisted milestone or checkpoint in Finalized block function * Fix:Test * Fix:Whitelisting of Milestone and Checkpoint process * Fix: Milestone JSON structure * Chg:Testcases changes * Fix:Change from VoteOnRootHash to VoteOnHash * Fix:Variable name fix * Fix:Finalized API * internal/jsre/deps: update web3.js bundle * Fix:milestone verifier * Chg:Handling the long future chain import issue * Fix:Lint issues * Fix:TestLowDiffLongChain and TestPrunedImportSide tests, used hardcoded value 128 instead of DefaultTriesInMemory value * Chg:Testcode for producing metrics * Chg:Milestong polling value to 32 secs * Add:Testcases * Add:Implemented the check to fetch the milestoneId from heimdall before locking the fork * Added GRPC method for FetchMilestoneID * Fix:lint issue * Fix:lint issue * Skiped out the tests which were mainly used to produce the supporting data * remove vcs build when running snyk * Add:Improved the logs and comments * fix linters * Skipped some test as they are panic due to timeout issue in github * Chg:Variable name LockerSprintNumber to LockedMilestoneNumber for better readablity and clarity * Chg:Conflicting variable names in milestone test file * Chg:Conflicting function names in milestone test file * fix : minor fix in TestInsertingSpanSizeBlocks * Fix:Mocking issue in TestInsertingSpanSizeBlocks * Fix:GRPC Polyproto Version * eth/downloader: skip peer drop due to whitelisting err * eth, tests/bor: bug fixes and minor refactor * Add:Implemented the milestone related functions in the HeimdallApp * Fix:Lint Errors & Remove:Redundant Code * Fix:Testing Errors * Fix:Bor integeration tests * Fix:Test errors * update heimdall client mock files * remove unused arguments * remove redundant code * Chg:Changed the milestone polling intervals * Add: added block finality from whitelisted checkpoint * skip future chain validation * Add:confirmation check of 16 blocks over the end block while voting for the milestone in GetVoteHash() function * Chg:Included endBlockNum in UnlockMutex function * Add:Property based test for milestone * Fix:Opening the lock while processing future milestone * Add:Property based test for futureMilestone * Defined the value of TempTriesInMemory * Fixed the finalized api * Fixed lint issues * eth: add logs while fetching and rewinding * fix linters: use default returns instead of recursive calls * Fix:Milestone intergration test * Add:GetVoteHash fn in mock backend * tests/bor: fix mock span * tests/bor: remove t.Parallel() * use bor namespace in ethclient, fix mock function --------- Co-authored-by: Vaibhav Jindal <vaibhavjindal29@gmail.com> Co-authored-by: VaibhavJindal <74560896+VAIBHAVJINDAL3012@users.noreply.github.com> Co-authored-by: Manav Darji <manavdarji.india@gmail.com> Co-authored-by: Evgeny Danienko <6655321@bk.ru> Co-authored-by: Shivam Sharma <shivam691999@gmail.com> Co-authored-by: Anshal Shukla <shukla.anshal85@gmail.com>
235 lines
6.5 KiB
Go
235 lines
6.5 KiB
Go
package whitelist
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/ethereum/go-ethereum/common"
|
|
"github.com/ethereum/go-ethereum/core/rawdb"
|
|
"github.com/ethereum/go-ethereum/core/types"
|
|
"github.com/ethereum/go-ethereum/ethdb"
|
|
)
|
|
|
|
var (
|
|
ErrMismatch = errors.New("mismatch error")
|
|
ErrNoRemote = errors.New("remote peer doesn't have a target block number")
|
|
|
|
ErrCheckpointMismatch = errors.New("checkpoint mismatch")
|
|
ErrLongFutureChain = errors.New("received future chain of unacceptable length")
|
|
ErrNoRemoteCheckpoint = errors.New("remote peer doesn't have a checkpoint")
|
|
)
|
|
|
|
type Service struct {
|
|
checkpointService
|
|
milestoneService
|
|
}
|
|
|
|
func NewService(db ethdb.Database) *Service {
|
|
var checkpointDoExist = true
|
|
|
|
checkpointNumber, checkpointHash, err := rawdb.ReadFinality[*rawdb.Checkpoint](db)
|
|
|
|
if err != nil {
|
|
checkpointDoExist = false
|
|
}
|
|
|
|
var milestoneDoExist = true
|
|
|
|
milestoneNumber, milestoneHash, err := rawdb.ReadFinality[*rawdb.Milestone](db)
|
|
if err != nil {
|
|
milestoneDoExist = false
|
|
}
|
|
|
|
locked, lockedMilestoneNumber, lockedMilestoneHash, lockedMilestoneIDs, err := rawdb.ReadLockField(db)
|
|
if err != nil || !locked {
|
|
locked = false
|
|
lockedMilestoneIDs = make(map[string]struct{})
|
|
}
|
|
|
|
order, list, err := rawdb.ReadFutureMilestoneList(db)
|
|
if err != nil {
|
|
order = make([]uint64, 0)
|
|
list = make(map[uint64]common.Hash)
|
|
}
|
|
|
|
return &Service{
|
|
&checkpoint{
|
|
finality[*rawdb.Checkpoint]{
|
|
doExist: checkpointDoExist,
|
|
Number: checkpointNumber,
|
|
Hash: checkpointHash,
|
|
interval: 256,
|
|
db: db,
|
|
},
|
|
},
|
|
|
|
&milestone{
|
|
finality: finality[*rawdb.Milestone]{
|
|
doExist: milestoneDoExist,
|
|
Number: milestoneNumber,
|
|
Hash: milestoneHash,
|
|
interval: 256,
|
|
db: db,
|
|
},
|
|
|
|
Locked: locked,
|
|
LockedMilestoneNumber: lockedMilestoneNumber,
|
|
LockedMilestoneHash: lockedMilestoneHash,
|
|
LockedMilestoneIDs: lockedMilestoneIDs,
|
|
FutureMilestoneList: list,
|
|
FutureMilestoneOrder: order,
|
|
MaxCapacity: 10,
|
|
},
|
|
}
|
|
}
|
|
|
|
// IsValidPeer checks if the chain we're about to receive from a peer is valid or not
|
|
// in terms of reorgs. We won't reorg beyond the last bor checkpoint submitted to mainchain and last milestone voted in the heimdall
|
|
func (s *Service) IsValidPeer(fetchHeadersByNumber func(number uint64, amount int, skip int, reverse bool) ([]*types.Header, []common.Hash, error)) (bool, error) {
|
|
checkpointBool, err := s.checkpointService.IsValidPeer(fetchHeadersByNumber)
|
|
if !checkpointBool {
|
|
return checkpointBool, err
|
|
}
|
|
|
|
milestoneBool, err := s.milestoneService.IsValidPeer(fetchHeadersByNumber)
|
|
if !milestoneBool {
|
|
return milestoneBool, err
|
|
}
|
|
|
|
return true, nil
|
|
}
|
|
|
|
func (s *Service) PurgeWhitelistedCheckpoint() {
|
|
s.checkpointService.Purge()
|
|
}
|
|
|
|
func (s *Service) PurgeWhitelistedMilestone() {
|
|
s.milestoneService.Purge()
|
|
}
|
|
|
|
func (s *Service) GetWhitelistedCheckpoint() (bool, uint64, common.Hash) {
|
|
return s.checkpointService.Get()
|
|
}
|
|
|
|
func (s *Service) GetWhitelistedMilestone() (bool, uint64, common.Hash) {
|
|
return s.milestoneService.Get()
|
|
}
|
|
|
|
func (s *Service) ProcessMilestone(endBlockNum uint64, endBlockHash common.Hash) {
|
|
s.milestoneService.Process(endBlockNum, endBlockHash)
|
|
}
|
|
|
|
func (s *Service) ProcessCheckpoint(endBlockNum uint64, endBlockHash common.Hash) {
|
|
s.checkpointService.Process(endBlockNum, endBlockHash)
|
|
}
|
|
|
|
func (s *Service) IsValidChain(currentHeader *types.Header, chain []*types.Header) (bool, error) {
|
|
checkpointBool, err := s.checkpointService.IsValidChain(currentHeader, chain)
|
|
if !checkpointBool {
|
|
return checkpointBool, err
|
|
}
|
|
|
|
milestoneBool, err := s.milestoneService.IsValidChain(currentHeader, chain)
|
|
if !milestoneBool {
|
|
return milestoneBool, err
|
|
}
|
|
|
|
return true, nil
|
|
}
|
|
|
|
func (s *Service) GetMilestoneIDsList() []string {
|
|
return s.milestoneService.GetMilestoneIDsList()
|
|
}
|
|
|
|
func splitChain(current uint64, chain []*types.Header) ([]*types.Header, []*types.Header) {
|
|
var (
|
|
pastChain []*types.Header
|
|
futureChain []*types.Header
|
|
first = chain[0].Number.Uint64()
|
|
last = chain[len(chain)-1].Number.Uint64()
|
|
)
|
|
|
|
if current >= first {
|
|
if len(chain) == 1 || current >= last {
|
|
pastChain = chain
|
|
} else {
|
|
pastChain = chain[:current-first+1]
|
|
}
|
|
}
|
|
|
|
if current < last {
|
|
if len(chain) == 1 || current < first {
|
|
futureChain = chain
|
|
} else {
|
|
futureChain = chain[current-first+1:]
|
|
}
|
|
}
|
|
|
|
return pastChain, futureChain
|
|
}
|
|
|
|
//nolint:unparam
|
|
func isValidChain(currentHeader *types.Header, chain []*types.Header, doExist bool, number uint64, hash common.Hash) (bool, error) {
|
|
// Check if we have milestone to validate incoming chain in memory
|
|
if !doExist {
|
|
// We don't have any entry, no additional validation will be possible
|
|
return true, nil
|
|
}
|
|
|
|
current := currentHeader.Number.Uint64()
|
|
|
|
// Check if imported chain is less than whitelisted number
|
|
if chain[len(chain)-1].Number.Uint64() < number {
|
|
if current >= number { //If current tip of the chain is greater than whitelist number then return false
|
|
return false, nil
|
|
} else {
|
|
return true, nil
|
|
}
|
|
}
|
|
|
|
// Split the chain into past and future chain
|
|
pastChain, _ := splitChain(current, chain)
|
|
|
|
// Iterate over the chain and validate against the last milestone
|
|
// It will handle all cases when the incoming chain has atleast one milestone
|
|
for i := len(pastChain) - 1; i >= 0; i-- {
|
|
if pastChain[i].Number.Uint64() == number {
|
|
res := pastChain[i].Hash() == hash
|
|
|
|
return res, nil
|
|
}
|
|
}
|
|
|
|
return true, nil
|
|
}
|
|
|
|
// FIXME: remoteHeader is not used
|
|
func isValidPeer(fetchHeadersByNumber func(number uint64, amount int, skip int, reverse bool) ([]*types.Header, []common.Hash, error), doExist bool, number uint64, hash common.Hash) (bool, error) {
|
|
// Check for availaibility of the last milestone block.
|
|
// This can be also be empty if our heimdall is not responding
|
|
// or we're running without it.
|
|
if !doExist {
|
|
// worst case, we don't have the milestone in memory
|
|
return true, nil
|
|
}
|
|
|
|
// todo: we can extract this as an interface and mock as well or just test IsValidChain in isolation from downloader passing fake fetchHeadersByNumber functions
|
|
headers, hashes, err := fetchHeadersByNumber(number, 1, 0, false)
|
|
if err != nil {
|
|
return false, fmt.Errorf("%w: last whitelisted block number %d, err %v", ErrNoRemote, number, err)
|
|
}
|
|
|
|
if len(headers) == 0 {
|
|
return false, fmt.Errorf("%w: last whitlisted block number %d", ErrNoRemote, number)
|
|
}
|
|
|
|
reqBlockNum := headers[0].Number.Uint64()
|
|
reqBlockHash := hashes[0]
|
|
|
|
// Check against the whitelisted blocks
|
|
if reqBlockNum == number && reqBlockHash == hash {
|
|
return true, nil
|
|
}
|
|
|
|
return false, ErrMismatch
|
|
}
|