mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-07-02 11:11:16 +00:00
39a9e49233
ABI.Pack returned `append(method.ID, arguments...)`. method.ID is derived from crypto.Keccak256(sig)[:4], which yields a slice of length 4 but capacity 32 (the full keccak hash buffer), and it is computed once and cached on the parsed method. When a method takes no arguments, the append has nothing to copy and returns method.ID's own backing array. The caller therefore received calldata that aliased the ABI's cached selector. Mutating that calldata, or a concurrent Pack of the same no-arg method, corrupted the cached selector and broke every subsequent encode of that method. (Methods with arguments always pack to >=32 bytes, so 4+32 > 32 forces a reallocation and they were never affected.) Copy method.ID into a fresh slice before appending the arguments so the returned calldata never shares storage with the cached selector. Add a regression test that packs a no-arg method, mutates the result, and verifies both the cached selector and a subsequent pack are unaffected. |
||
|---|---|---|
| .. | ||
| abi | ||
| external | ||
| keystore | ||
| scwallet | ||
| usbwallet | ||
| accounts.go | ||
| accounts_test.go | ||
| errors.go | ||
| hd.go | ||
| hd_test.go | ||
| manager.go | ||
| sort.go | ||
| url.go | ||
| url_test.go | ||