mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-03-01 17:13:45 +00:00
9045b79bc2
This PR modifies how the metrics library handles `Enabled`: previously, the package `init` decided whether to serve real metrics or just dummy-types. This has several drawbacks: - During pkg init, we need to determine whether metrics are enabled or not. So we first hacked in a check if certain geth-specific commandline-flags were enabled. Then we added a similar check for geth-env-vars. Then we almost added a very elaborate check for toml-config-file, plus toml parsing. - Using "real" types and dummy types interchangeably means that everything is hidden behind interfaces. This has a performance penalty, and also it just adds a lot of code. This PR removes the interface stuff, uses concrete types, and allows for the setting of Enabled to happen later. It is still assumed that `metrics.Enable()` is invoked early on. The somewhat 'heavy' operations, such as ticking meters and exp-decay, now checks the enable-flag to prevent resource leak. The change may be large, but it's mostly pretty trivial, and from the last time I gutted the metrics, I ensured that we have fairly good test coverage. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
82 lines
3.1 KiB
Go
82 lines
3.1 KiB
Go
package metrics
|
|
|
|
import (
|
|
"time"
|
|
)
|
|
|
|
type Logger interface {
|
|
Printf(format string, v ...interface{})
|
|
}
|
|
|
|
func Log(r Registry, freq time.Duration, l Logger) {
|
|
LogScaled(r, freq, time.Nanosecond, l)
|
|
}
|
|
|
|
// Output each metric in the given registry periodically using the given
|
|
// logger. Print timings in `scale` units (eg time.Millisecond) rather than nanos.
|
|
func LogScaled(r Registry, freq time.Duration, scale time.Duration, l Logger) {
|
|
du := float64(scale)
|
|
duSuffix := scale.String()[1:]
|
|
|
|
for range time.Tick(freq) {
|
|
r.Each(func(name string, i interface{}) {
|
|
switch metric := i.(type) {
|
|
case *Counter:
|
|
l.Printf("counter %s\n", name)
|
|
l.Printf(" count: %9d\n", metric.Snapshot().Count())
|
|
case *CounterFloat64:
|
|
l.Printf("counter %s\n", name)
|
|
l.Printf(" count: %f\n", metric.Snapshot().Count())
|
|
case *Gauge:
|
|
l.Printf("gauge %s\n", name)
|
|
l.Printf(" value: %9d\n", metric.Snapshot().Value())
|
|
case *GaugeFloat64:
|
|
l.Printf("gauge %s\n", name)
|
|
l.Printf(" value: %f\n", metric.Snapshot().Value())
|
|
case *GaugeInfo:
|
|
l.Printf("gauge %s\n", name)
|
|
l.Printf(" value: %s\n", metric.Snapshot().Value())
|
|
case Histogram:
|
|
h := metric.Snapshot()
|
|
ps := h.Percentiles([]float64{0.5, 0.75, 0.95, 0.99, 0.999})
|
|
l.Printf("histogram %s\n", name)
|
|
l.Printf(" count: %9d\n", h.Count())
|
|
l.Printf(" min: %9d\n", h.Min())
|
|
l.Printf(" max: %9d\n", h.Max())
|
|
l.Printf(" mean: %12.2f\n", h.Mean())
|
|
l.Printf(" stddev: %12.2f\n", h.StdDev())
|
|
l.Printf(" median: %12.2f\n", ps[0])
|
|
l.Printf(" 75%%: %12.2f\n", ps[1])
|
|
l.Printf(" 95%%: %12.2f\n", ps[2])
|
|
l.Printf(" 99%%: %12.2f\n", ps[3])
|
|
l.Printf(" 99.9%%: %12.2f\n", ps[4])
|
|
case *Meter:
|
|
m := metric.Snapshot()
|
|
l.Printf("meter %s\n", name)
|
|
l.Printf(" count: %9d\n", m.Count())
|
|
l.Printf(" 1-min rate: %12.2f\n", m.Rate1())
|
|
l.Printf(" 5-min rate: %12.2f\n", m.Rate5())
|
|
l.Printf(" 15-min rate: %12.2f\n", m.Rate15())
|
|
l.Printf(" mean rate: %12.2f\n", m.RateMean())
|
|
case *Timer:
|
|
t := metric.Snapshot()
|
|
ps := t.Percentiles([]float64{0.5, 0.75, 0.95, 0.99, 0.999})
|
|
l.Printf("timer %s\n", name)
|
|
l.Printf(" count: %9d\n", t.Count())
|
|
l.Printf(" min: %12.2f%s\n", float64(t.Min())/du, duSuffix)
|
|
l.Printf(" max: %12.2f%s\n", float64(t.Max())/du, duSuffix)
|
|
l.Printf(" mean: %12.2f%s\n", t.Mean()/du, duSuffix)
|
|
l.Printf(" stddev: %12.2f%s\n", t.StdDev()/du, duSuffix)
|
|
l.Printf(" median: %12.2f%s\n", ps[0]/du, duSuffix)
|
|
l.Printf(" 75%%: %12.2f%s\n", ps[1]/du, duSuffix)
|
|
l.Printf(" 95%%: %12.2f%s\n", ps[2]/du, duSuffix)
|
|
l.Printf(" 99%%: %12.2f%s\n", ps[3]/du, duSuffix)
|
|
l.Printf(" 99.9%%: %12.2f%s\n", ps[4]/du, duSuffix)
|
|
l.Printf(" 1-min rate: %12.2f\n", t.Rate1())
|
|
l.Printf(" 5-min rate: %12.2f\n", t.Rate5())
|
|
l.Printf(" 15-min rate: %12.2f\n", t.Rate15())
|
|
l.Printf(" mean rate: %12.2f\n", t.RateMean())
|
|
}
|
|
})
|
|
}
|
|
}
|