forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-03-01 17:13:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
go-ethereum/p2p
History
Ferenc Szabo 50b872bf05 p2p, swarm: fix node up races by granular locking (#18976) 
* swarm/network: DRY out repeated giga comment

I not necessarily agree with the way we wait for event propagation.
But I truly disagree with having duplicated giga comments.

* p2p/simulations: encapsulate Node.Up field so we avoid data races

The Node.Up field was accessed concurrently without "proper" locking.
There was a lock on Network and that was used sometimes to access
the  field. Other times the locking was missed and we had
a data race.

For example: https://github.com/ethereum/go-ethereum/pull/18464
The case above was solved, but there were still intermittent/hard to
reproduce races. So let's solve the issue permanently.

resolves: ethersphere/go-ethereum#1146

* p2p/simulations: fix unmarshal of simulations.Node

Making Node.Up field private in 13292ee897
broke TestHTTPNetwork and TestHTTPSnapshot. Because the default
UnmarshalJSON does not handle unexported fields.

Important: The fix is partial and not proper to my taste. But I cut
scope as I think the fix may require a change to the current
serialization format. New ticket:
https://github.com/ethersphere/go-ethereum/issues/1177

* p2p/simulations: Add a sanity test case for Node.Config UnmarshalJSON

* p2p/simulations: revert back to defer Unlock() pattern for Network

It's a good patten to call `defer Unlock()` right after `Lock()` so
(new) error cases won't miss to unlock. Let's get back to that pattern.

The patten was abandoned in 85a79b3ad3,
while fixing a data race. That data race does not exist anymore,
since the Node.Up field got hidden behind its own lock.

* p2p/simulations: consistent naming for test providers Node.UnmarshalJSON

* p2p/simulations: remove JSON annotation from private fields of Node

As unexported fields are not serialized.

* p2p/simulations: fix deadlock in Network.GetRandomDownNode()

Problem: GetRandomDownNode() locks -> getDownNodeIDs() ->
GetNodes() tries to lock -> deadlock

On Network type, unexported functions must assume that `net.lock`
is already acquired and should not call exported functions which
might try to lock again.

* p2p/simulations: ensure method conformity for Network

Connect* methods were moved to p2p/simulations.Network from
swarm/network/simulation. However these new methods did not follow
the pattern of Network methods, i.e., all exported method locks
the whole Network either for read or write.

* p2p/simulations: fix deadlock during network shutdown

`TestDiscoveryPersistenceSimulationSimAdapter` often got into deadlock.
The execution was stuck on two locks, i.e, `Kademlia.lock` and
`p2p/simulations.Network.lock`. Usually the test got stuck once in each
20 executions with high confidence.

`Kademlia` was stuck in `Kademlia.EachAddr()` and `Network` in
`Network.Stop()`.

Solution: in `Network.Stop()` `net.lock` must be released before
calling `node.Stop()` as stopping a node (somehow - I did not find
the exact code path) causes `Network.InitConn()` to be called from
`Kademlia.SuggestPeer()` and that blocks on `net.lock`.

Related ticket: https://github.com/ethersphere/go-ethereum/issues/1223

* swarm/state: simplify if statement in DBStore.Put()

* p2p/simulations: remove faulty godoc from private function

The comment started with the wrong method name.

The method is simple and self explanatory. Also, it's private.
=> Let's just remove the comment.
2019-02-18 07:38:14 +01:00
..
discover p2p/discover: improve table addition code (#18974) 2019-01-31 11:48:54 +01:00
discv5 vendor, crypto, swarm: switch over to upstream sha3 package 2019-01-04 09:26:07 +02:00
enode p2p/discover, p2p/enode: rework endpoint proof handling, packet logging (#18963) 2019-01-29 17:39:20 +01:00
enr p2p, p2p/discover: add signed ENR generation (#17753) 2018-10-12 11:47:24 +02:00
nat p2p, p2p/discover: add signed ENR generation (#17753) 2018-10-12 11:47:24 +02:00
netutil p2p, p2p/discover: add signed ENR generation (#17753) 2018-10-12 11:47:24 +02:00
protocols p2p/protocols: fix possible metrics loss in AccountingMetrics (#18956) 2019-01-29 15:19:54 +01:00
simulations p2p, swarm: fix node up races by granular locking (#18976) 2019-02-18 07:38:14 +01:00
testing p2p/testing, swarm: remove unused testing.T in protocol tester (#18500) 2019-01-24 17:23:34 +01:00
dial.go p2p: meter peer traffic, emit metered peer events (#17695) 2018-10-16 00:40:51 +02:00
dial_test.go p2p, p2p/discover: add signed ENR generation (#17753) 2018-10-12 11:47:24 +02:00
message.go all: new p2p node representation (#17643) 2018-09-25 00:59:00 +02:00
message_test.go all: fix go vet warnings 2016-04-15 11:17:27 +02:00
metrics.go metrics, p2p: add ephemeral registry (#18067) 2018-11-09 10:20:51 +01:00
peer.go p2p: add enode URL to PeerInfo (#17838) 2018-10-04 18:13:21 +03:00
peer_error.go p2p: fix some golint warnings (#16577) 2018-05-08 13:08:43 +02:00
peer_test.go all: new p2p node representation (#17643) 2018-09-25 00:59:00 +02:00
protocol.go p2p, p2p/discover: add signed ENR generation (#17753) 2018-10-12 11:47:24 +02:00
rlpx.go vendor, crypto, swarm: switch over to upstream sha3 package 2019-01-04 09:26:07 +02:00
rlpx_test.go vendor, crypto, swarm: switch over to upstream sha3 package 2019-01-04 09:26:07 +02:00
server.go p2p: use errors.New instead of fmt.Errorf (#18193) 2018-11-30 22:38:37 +01:00
server_test.go vendor, crypto, swarm: switch over to upstream sha3 package 2019-01-04 09:26:07 +02:00