Daniel Liu 6beee27886 metrics, cmd/XDC: change init-process of metrics (#30814) ... This PR modifies how the metrics library handles `Enabled`: previously, the package `init` decided whether to serve real metrics or just dummy-types. This has several drawbacks: - During pkg init, we need to determine whether metrics are enabled or not. So we first hacked in a check if certain geth-specific commandline-flags were enabled. Then we added a similar check for geth-env-vars. Then we almost added a very elaborate check for toml-config-file, plus toml parsing. - Using "real" types and dummy types interchangeably means that everything is hidden behind interfaces. This has a performance penalty, and also it just adds a lot of code. This PR removes the interface stuff, uses concrete types, and allows for the setting of Enabled to happen later. It is still assumed that `metrics.Enable()` is invoked early on. The somewhat 'heavy' operations, such as ticking meters and exp-decay, now checks the enable-flag to prevent resource leak. The change may be large, but it's mostly pretty trivial, and from the last time I gutted the metrics, I ensured that we have fairly good test coverage. --------- Co-authored-by: Felix Lange <fjl@twurst.com>		2024-12-13 14:00:14 +08:00
..
cmd.go	all: use errrors.New instead of empty fmt.Errorf	2024-06-14 19:19:21 +08:00
flags.go	metrics, cmd/XDC: change init-process of metrics (#30814)	2024-12-13 14:00:14 +08:00
flags_legacy.go	cmd, core, metrics: always report expensive metrics (#29191)	2024-12-13 14:00:13 +08:00
flags_test.go	cmd/utils: allow for multiple influxdb flags (#18520)	2024-12-13 14:00:11 +08:00
utils.go	metrics, cmd/geth: informational metrics (prometheus, influxdb, opentsb) (#24877)	2024-12-13 14:00:13 +08:00