go-ethereum/p2p
Felix Lange 706cf1c779
p2p/discover: fix crash when revalidated node is removed (#29864)
In #29572, I assumed the revalidation list that the node is contained in could only ever
be changed by the outcome of a revalidation request. But turns out that's not true: if the
node gets removed due to FINDNODE failure, it will also be removed from the list it is in.
This causes a crash.

The invariant is: while node is in table, it is always in exactly one of the two lists. So
it seems best to store a pointer to the current list within the node itself.
2024-06-11 14:07:20 +05:30
..
discover p2p/discover: fix crash when revalidated node is removed (#29864) 2024-06-11 14:07:20 +05:30
dnsdisc merge geth v1.12.2 into develop 2023-08-18 14:05:34 +05:30
enode merge develop 2023-10-16 23:37:44 +05:30
enr dev: fix: most of wsl lint issues 2023-06-15 15:48:26 +02:00
msgrate Revert "Merge upstream_merge branch to develop (#1229)" 2024-05-28 14:10:49 +05:30
nat Revert "Merge upstream_merge branch to develop (#1229)" 2024-05-28 14:10:49 +05:30
netutil merge geth v1.12.2 into develop 2023-08-18 14:05:34 +05:30
nodestate merge geth v1.12.2 into develop 2023-08-18 14:05:34 +05:30
rlpx cherry pick to fix lints 2024-05-05 15:47:42 +05:30
simulations Revert "Merge upstream_merge branch to develop (#1229)" 2024-05-28 14:10:49 +05:30
tracker dev: fix: most of wsl lint issues 2023-06-15 15:48:26 +02:00
dial.go merge geth v1.12.2 into develop 2023-08-18 14:05:34 +05:30
dial_test.go merge geth v1.12.2 into develop 2023-08-18 14:05:34 +05:30
message.go merge geth v1.12.2 into develop 2023-08-18 14:05:34 +05:30
message_test.go dev: fix: most of wsl lint issues 2023-06-15 15:48:26 +02:00
metrics.go merge geth v1.12.2 into develop 2023-08-18 14:05:34 +05:30
peer.go fix tests 2023-09-22 15:03:24 +05:30
peer_error.go dev: fix: most of wsl lint issues 2023-06-15 15:48:26 +02:00
peer_test.go dev: fix: most of wsl lint issues 2023-06-15 15:48:26 +02:00
protocol.go fix linters 2023-09-21 10:50:01 +05:30
server.go p2p/discover: improved node revalidation (#29572) 2024-06-11 13:53:35 +05:30
server_nat.go cmd/bootnode, p2p: support for alternate mapped ports (#26359) 2023-07-14 14:58:27 +02:00
server_nat_test.go cmd/bootnode, p2p: support for alternate mapped ports (#26359) 2023-07-14 14:58:27 +02:00
server_test.go merge geth v1.12.2 into develop 2023-08-18 14:05:34 +05:30
transport.go dev: fix: most of wsl lint issues 2023-06-15 15:48:26 +02:00
transport_test.go dev: fix: most of wsl lint issues 2023-06-15 15:48:26 +02:00
util.go dev: fix: most of wsl lint issues 2023-06-15 15:48:26 +02:00
util_test.go dev: fix: most of wsl lint issues 2023-06-15 15:48:26 +02:00