go-ethereum/cmd/devp2p/internal
cui cb387c9bc3
Some checks are pending
/ Linux Build (push) Waiting to run
/ Linux Build (arm) (push) Waiting to run
/ Keeper Build (push) Waiting to run
/ Windows Build (push) Waiting to run
/ Docker Image (push) Waiting to run
cmd/devp2p/internal/ethtest: validate received txs, not the sent ones (#35170)
sendInvalidTxs's *eth.TransactionsPacket case iterated `txs` — the
locally-sent invalid transactions, every one of which is in `invalids`
by construction — instead of the transactions actually carried by the
received packet. As a result the loop returned "received bad tx" on the
very first TransactionsPacket the peer sent, regardless of its contents,
and never inspected what was really propagated.

Iterate msg.Items() (the decoded contents of the received packet) so the
"node must not propagate invalid txs" conformance check tests the real
condition instead of producing a false negative.

---------

Co-authored-by: Bosul Mun <bsbs8645@snu.ac.kr>
2026-06-16 15:31:02 +02:00
..
ethtest cmd/devp2p/internal/ethtest: validate received txs, not the sent ones (#35170) 2026-06-16 15:31:02 +02:00
v4test cmd/devp2p/internal/v4test: add test for ENRRequest (#32303) 2025-07-31 12:13:36 +02:00
v5test cmd/devp2p/internal/v5test: fix hive test for discv5 findnode results (#34043) 2026-04-14 12:15:39 +02:00