mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-06-20 21:54:30 +00:00
## Why this should be merged In lieu of modifications to `core.IntrinsicGas()`, required for support of Warp in SAE. If we were to introduce variadic `options.Option`s to `IntrinsicGas()`, it's impossible to guarantee that they would always be passed. The `types.Transaction` itself isn't actually passed to `IntrinsicGas()` either, so we can't rely on it to carry payloads/hooks. ## How this works `vm.Hooks` are extended to include `PreprocessingGasCharge(tx common.Hash) (uint64, error)`, which returns the amount of gas to be charged between `core.IntrinsicGas` and `vm.EVM` execution charges. The two entry points to execution, `vm.EVM.Call()` and `vm.EVM.Create()` are modified to first spend said charge before running upstream logic. The new hook is defined on a separate interface definition, embedded in `vm.Hooks`, to allow types to implement just that method and enforce it with the `var _ vm.Preprocessor = (*impl)(nil)` pattern. ## How this was tested Integration tests via both `core.ApplyTransaction()` and `core.ApplyMessage()`. The former is more comprehensive, while the latter allows for inspection of interim error values. --------- Signed-off-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Austin Larson <78000745+alarso16@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| devkey.go | ||
| devkey_test.go | ||
| dummy.go | ||
| evm.go | ||
| rand.go | ||