mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-06-22 14:44:30 +00:00
9021836d7d
## Why this should be merged In lieu of modifications to `core.IntrinsicGas()`, required for support of Warp in SAE. If we were to introduce variadic `options.Option`s to `IntrinsicGas()`, it's impossible to guarantee that they would always be passed. The `types.Transaction` itself isn't actually passed to `IntrinsicGas()` either, so we can't rely on it to carry payloads/hooks. ## How this works `vm.Hooks` are extended to include `PreprocessingGasCharge(tx common.Hash) (uint64, error)`, which returns the amount of gas to be charged between `core.IntrinsicGas` and `vm.EVM` execution charges. The two entry points to execution, `vm.EVM.Call()` and `vm.EVM.Create()` are modified to first spend said charge before running upstream logic. The new hook is defined on a separate interface definition, embedded in `vm.Hooks`, to allow types to implement just that method and enforce it with the `var _ vm.Preprocessor = (*impl)(nil)` pattern. ## How this was tested Integration tests via both `core.ApplyTransaction()` and `core.ApplyMessage()`. The former is more comprehensive, while the latter allows for inspection of interim error values. --------- Signed-off-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Austin Larson <78000745+alarso16@users.noreply.github.com>
115 lines
3.5 KiB
Go
115 lines
3.5 KiB
Go
// Copyright 2024-2025 the libevm authors.
|
|
//
|
|
// The libevm additions to go-ethereum are free software: you can redistribute
|
|
// them and/or modify them under the terms of the GNU Lesser General Public License
|
|
// as published by the Free Software Foundation, either version 3 of the License,
|
|
// or (at your option) any later version.
|
|
//
|
|
// The libevm additions are distributed in the hope that they will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser
|
|
// General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see
|
|
// <http://www.gnu.org/licenses/>.
|
|
package vm
|
|
|
|
import (
|
|
"math/big"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/ava-labs/libevm/common"
|
|
"github.com/ava-labs/libevm/libevm"
|
|
"github.com/ava-labs/libevm/params"
|
|
)
|
|
|
|
type evmArgOverrider struct {
|
|
newEVMchainID int64
|
|
|
|
gotResetChainID *big.Int
|
|
resetTxContextTo TxContext
|
|
resetStateDBTo StateDB
|
|
}
|
|
|
|
func (o *evmArgOverrider) OverrideNewEVMArgs(args *NewEVMArgs) *NewEVMArgs {
|
|
args.ChainConfig = ¶ms.ChainConfig{ChainID: big.NewInt(o.newEVMchainID)}
|
|
return args
|
|
}
|
|
|
|
func (o *evmArgOverrider) OverrideEVMResetArgs(r params.Rules, _ *EVMResetArgs) *EVMResetArgs {
|
|
o.gotResetChainID = r.ChainID
|
|
return &EVMResetArgs{
|
|
TxContext: o.resetTxContextTo,
|
|
StateDB: o.resetStateDBTo,
|
|
}
|
|
}
|
|
|
|
func (*evmArgOverrider) PreprocessingGasCharge(common.Hash) (uint64, error) {
|
|
return 0, nil
|
|
}
|
|
|
|
func (o *evmArgOverrider) register(t *testing.T) {
|
|
t.Helper()
|
|
TestOnlyClearRegisteredHooks()
|
|
RegisterHooks(o)
|
|
t.Cleanup(TestOnlyClearRegisteredHooks)
|
|
}
|
|
|
|
func TestOverrideNewEVMArgs(t *testing.T) {
|
|
// The overrideNewEVMArgs function accepts and returns all arguments to
|
|
// NewEVM(), in order. Here we lock in our assumption of that order. If this
|
|
// breaks then all functionality overriding the args MUST be updated.
|
|
var _ func(BlockContext, TxContext, StateDB, *params.ChainConfig, Config) *EVM = NewEVM
|
|
|
|
const chainID = 13579
|
|
hooks := evmArgOverrider{newEVMchainID: chainID}
|
|
hooks.register(t)
|
|
|
|
assertChainID := func(t *testing.T, want int64) {
|
|
t.Helper()
|
|
evm := NewEVM(BlockContext{}, TxContext{}, nil, nil, Config{})
|
|
got := evm.ChainConfig().ChainID
|
|
require.Equalf(t, big.NewInt(want), got, "%T.ChainConfig().ChainID set by NewEVM() hook", evm)
|
|
}
|
|
assertChainID(t, chainID)
|
|
|
|
t.Run("WithTempRegisteredHooks", func(t *testing.T) {
|
|
err := libevm.WithTemporaryExtrasLock(func(lock libevm.ExtrasLock) error {
|
|
override := evmArgOverrider{newEVMchainID: 24680}
|
|
return WithTempRegisteredHooks(lock, &override, func() error {
|
|
assertChainID(t, override.newEVMchainID)
|
|
return nil
|
|
})
|
|
})
|
|
require.NoError(t, err)
|
|
t.Run("after", func(t *testing.T) {
|
|
assertChainID(t, chainID)
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestOverrideEVMResetArgs(t *testing.T) {
|
|
// Equivalent to rationale for TestOverrideNewEVMArgs above.
|
|
var _ func(TxContext, StateDB) = (*EVM)(nil).Reset
|
|
|
|
const (
|
|
chainID = 0xc0ffee
|
|
gasPrice = 1357924680
|
|
)
|
|
hooks := &evmArgOverrider{
|
|
newEVMchainID: chainID,
|
|
resetTxContextTo: TxContext{
|
|
GasPrice: big.NewInt(gasPrice),
|
|
},
|
|
}
|
|
hooks.register(t)
|
|
|
|
evm := NewEVM(BlockContext{}, TxContext{}, nil, nil, Config{})
|
|
evm.Reset(TxContext{}, nil)
|
|
assert.Equalf(t, big.NewInt(chainID), hooks.gotResetChainID, "%T.ChainID passed to Reset() hook", params.Rules{})
|
|
assert.Equalf(t, big.NewInt(gasPrice), evm.GasPrice, "%T.GasPrice set by Reset() hook", evm)
|
|
}
|