mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-02-26 15:47:21 +00:00
Adding values to the witness introduces a new class of issues for computing gas: if there is not enough gas to cover adding an item to the witness, then the item should not be added to the witness. The problem happens when several items are added together, and that process runs out of gas. The witness gas computation needs a way to signal that not enough gas was provided. These values can not be hardcoded, however, as they are context dependent, i.e. two calls to the same function with the same parameters can give two different results. The approach is to return both the gas that was actually consumed, and the gas that was necessary. If the values don't match, then a witness update OOG'd. The caller should then charge the `consumed` value (remaining gas will be 0) and error out. Why not return a boolean instead of the wanted value? Because when several items are touched, we want to distinguish which item lacked gas. --------- Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
142 lines
4.9 KiB
Go
142 lines
4.9 KiB
Go
// Copyright 2021 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package state
|
|
|
|
import (
|
|
"math"
|
|
"testing"
|
|
|
|
"github.com/ethereum/go-ethereum/common"
|
|
"github.com/ethereum/go-ethereum/params"
|
|
"github.com/ethereum/go-ethereum/trie/utils"
|
|
)
|
|
|
|
var (
|
|
testAddr [20]byte
|
|
testAddr2 [20]byte
|
|
)
|
|
|
|
func init() {
|
|
for i := byte(0); i < 20; i++ {
|
|
testAddr[i] = i
|
|
testAddr[2] = 2 * i
|
|
}
|
|
}
|
|
|
|
func TestAccountHeaderGas(t *testing.T) {
|
|
ae := NewAccessEvents(utils.NewPointCache(1024))
|
|
|
|
// Check cold read cost
|
|
gas := ae.BasicDataGas(testAddr, false, math.MaxUint64, false)
|
|
if want := params.WitnessBranchReadCost + params.WitnessChunkReadCost; gas != want {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, want)
|
|
}
|
|
|
|
// Check warm read cost
|
|
gas = ae.BasicDataGas(testAddr, false, math.MaxUint64, false)
|
|
if gas != 0 {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, 0)
|
|
}
|
|
|
|
// Check cold read costs in the same group no longer incur the branch read cost
|
|
gas = ae.CodeHashGas(testAddr, false, math.MaxUint64, false)
|
|
if gas != params.WitnessChunkReadCost {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, params.WitnessChunkReadCost)
|
|
}
|
|
|
|
// Check cold write cost
|
|
gas = ae.BasicDataGas(testAddr, true, math.MaxUint64, false)
|
|
if want := params.WitnessBranchWriteCost + params.WitnessChunkWriteCost; gas != want {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, want)
|
|
}
|
|
|
|
// Check warm write cost
|
|
gas = ae.BasicDataGas(testAddr, true, math.MaxUint64, false)
|
|
if gas != 0 {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, 0)
|
|
}
|
|
|
|
// Check a write without a read charges both read and write costs
|
|
gas = ae.BasicDataGas(testAddr2, true, math.MaxUint64, false)
|
|
if want := params.WitnessBranchReadCost + params.WitnessBranchWriteCost + params.WitnessChunkWriteCost + params.WitnessChunkReadCost; gas != want {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, want)
|
|
}
|
|
|
|
// Check that a write followed by a read charges nothing
|
|
gas = ae.BasicDataGas(testAddr2, false, math.MaxUint64, false)
|
|
if gas != 0 {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, 0)
|
|
}
|
|
|
|
// Check that reading a slot from the account header only charges the
|
|
// chunk read cost.
|
|
gas = ae.SlotGas(testAddr, common.Hash{}, false, math.MaxUint64, false)
|
|
if gas != params.WitnessChunkReadCost {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, params.WitnessChunkReadCost)
|
|
}
|
|
}
|
|
|
|
// TestContractCreateInitGas checks that the gas cost of contract creation is correctly
|
|
// calculated.
|
|
func TestContractCreateInitGas(t *testing.T) {
|
|
ae := NewAccessEvents(utils.NewPointCache(1024))
|
|
|
|
var testAddr [20]byte
|
|
for i := byte(0); i < 20; i++ {
|
|
testAddr[i] = i
|
|
}
|
|
|
|
// Check cold read cost, without a value
|
|
gas, _ := ae.ContractCreateInitGas(testAddr, math.MaxUint64)
|
|
if want := params.WitnessBranchWriteCost + params.WitnessBranchReadCost + 2*params.WitnessChunkWriteCost + 2*params.WitnessChunkReadCost; gas != want {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, want)
|
|
}
|
|
|
|
// Check warm read cost
|
|
gas, _ = ae.ContractCreateInitGas(testAddr, math.MaxUint64)
|
|
if gas != 0 {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, 0)
|
|
}
|
|
}
|
|
|
|
// TestMessageCallGas checks that the gas cost of message calls is correctly
|
|
// calculated.
|
|
func TestMessageCallGas(t *testing.T) {
|
|
ae := NewAccessEvents(utils.NewPointCache(1024))
|
|
|
|
// Check cold read cost, without a value
|
|
gas := ae.MessageCallGas(testAddr, math.MaxUint64)
|
|
if want := params.WitnessBranchReadCost + params.WitnessChunkReadCost; gas != want {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, want)
|
|
}
|
|
|
|
// Check that reading the basic data and code hash of the same account does not incur the branch read cost
|
|
gas = ae.BasicDataGas(testAddr, false, math.MaxUint64, false)
|
|
if gas != 0 {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, 0)
|
|
}
|
|
gas = ae.CodeHashGas(testAddr, false, math.MaxUint64, false)
|
|
if gas != params.WitnessChunkReadCost {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, 0)
|
|
}
|
|
|
|
// Check warm read cost
|
|
gas = ae.MessageCallGas(testAddr, math.MaxUint64)
|
|
if gas != params.WarmStorageReadCostEIP2929 {
|
|
t.Fatalf("incorrect gas computed, got %d, want %d", gas, params.WarmStorageReadCostEIP2929)
|
|
}
|
|
}
|