mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-06-20 13:44:31 +00:00
aa183c52be
## Why this should be merged
This is a precursor to being able to override `types.Header` RLP
{en,de}coding. As there is already a `Header.EncodeRLP()` method we
either have to modify the generated code or rename the generated
method—this PR does the latter.
## How this works
The `rlpgen -internal_methods` flag changes the generated methods from
`EncodeRLP()` and `DecodeRLP()` to `encodeRLP()` and `decodeRLP()`,
respectively. A new CI job checks that generated code is up to date. We
can then implement our own `Header.EncodeRLP()` that either overrides or
falls back on the original.
It appears that `core/gen_genesis.go` was out of date but only because
of formatting.
## How this was tested
I deliberately excluded the change to `core/types/gen_header_rlp.go` to
confirm that the new workflow
[detects](https://github.com/ava-labs/libevm/actions/runs/12259667481/job/34202386378?pr=86#step:5:92)
the change and fails. The actual change can be inspected via the code
diff.
43 lines
1.3 KiB
YAML
43 lines
1.3 KiB
YAML
name: Go
|
|
|
|
on:
|
|
push:
|
|
branches: [ main, 'release/**' ]
|
|
pull_request:
|
|
branches: [ main, 'release/**' ]
|
|
workflow_dispatch:
|
|
|
|
jobs:
|
|
go_test_short:
|
|
env:
|
|
FLAKY_REGEX: 'ava-labs/libevm/(triedb/pathdb|eth|eth/tracers/js|eth/tracers/logger|accounts/abi/bind|accounts/keystore|eth/downloader|miner|ethclient|ethclient/gethclient|eth/catalyst)$'
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- name: Set up Go
|
|
uses: actions/setup-go@v5
|
|
with:
|
|
go-version: 1.21.4
|
|
- name: Run flaky tests sequentially
|
|
run: | # Upstream flakes are race conditions exacerbated by concurrent tests
|
|
go list ./... | grep -P "${FLAKY_REGEX}" | xargs -n 1 go test -short;
|
|
- name: Run non-flaky tests concurrently
|
|
run: |
|
|
go test -short $(go list ./... | grep -Pv "${FLAKY_REGEX}");
|
|
|
|
go_generate:
|
|
env:
|
|
EXCLUDE_REGEX: 'ava-labs/libevm/(accounts/usbwallet/trezor)$'
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- name: Set up Go
|
|
uses: actions/setup-go@v5
|
|
with:
|
|
go-version: 1.21.4
|
|
|
|
- name: Run `go generate`
|
|
run: go list ./... | grep -Pv "${EXCLUDE_REGEX}" | xargs go generate;
|
|
|
|
- name: git diff
|
|
run: git diff --exit-code
|