mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-06-12 09:51:36 +00:00
8a5e777fde
Replace the BinaryNode interface (which uses Go interface pointers that the GC must scan) with NodeRef uint32 indices into typed arena pools. NodeRef packs a 2-bit kind tag and 30-bit pool index into a single uint32, making it invisible to the garbage collector. NodeStore manages chunked typed pools per node kind: - InternalNode pool: ZERO Go pointers (children are NodeRef, hash is [32]byte) → allocated in noscan spans, GC skips entirely - HashedNode pool: ZERO Go pointers → noscan spans - StemNode pool: ONE pointer per node (valueData []byte) → minimal GC For a trie with 25K InternalNodes, this reduces GC-scanned pointer-words from ~125K to ~10K (85% reduction). CPU profiling showed 44% of time in GC; this refactor directly addresses that bottleneck. Serialization format is unchanged — the on-disk representation is fully compatible. All existing tests pass.
57 lines
2.2 KiB
Go
57 lines
2.2 KiB
Go
// Copyright 2025 go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package bintrie
|
|
|
|
// NodeKind identifies the type of a trie node stored in a NodeRef.
|
|
type NodeKind uint8
|
|
|
|
const (
|
|
KindEmpty NodeKind = iota // no node
|
|
KindInternal // internal binary branching node
|
|
KindStem // leaf group containing up to 256 values
|
|
KindHashed // unresolved node (hash only)
|
|
KindInvalid // sentinel for validation
|
|
)
|
|
|
|
// NodeRef is a compact, GC-invisible reference to a node in a NodeStore.
|
|
// It packs a 2-bit type tag (bits 31-30) and a 30-bit index (bits 29-0)
|
|
// into a single uint32. Because NodeRef contains no Go pointers, slices
|
|
// of structs containing NodeRef fields are allocated in noscan spans —
|
|
// the garbage collector never examines them.
|
|
type NodeRef uint32
|
|
|
|
const (
|
|
kindShift uint32 = 30
|
|
indexMask uint32 = (1 << kindShift) - 1
|
|
|
|
// EmptyRef is the zero-value NodeRef, representing an empty node.
|
|
EmptyRef NodeRef = 0
|
|
)
|
|
|
|
// MakeRef creates a NodeRef from a kind and pool index.
|
|
func MakeRef(kind NodeKind, idx uint32) NodeRef {
|
|
return NodeRef(uint32(kind)<<kindShift | (idx & indexMask))
|
|
}
|
|
|
|
// Kind returns the node type tag.
|
|
func (r NodeRef) Kind() NodeKind { return NodeKind(uint32(r) >> kindShift) }
|
|
|
|
// Index returns the pool index within the node's typed pool.
|
|
func (r NodeRef) Index() uint32 { return uint32(r) & indexMask }
|
|
|
|
// IsEmpty returns true if this ref represents an empty node.
|
|
func (r NodeRef) IsEmpty() bool { return r == EmptyRef }
|