mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-04-15 22:28:35 +00:00
This PR simplifies the implementation of EIP-7610 by eliminating the
need to check storage emptiness during contract deployment.
EIP-7610 specifies that contract creation must be rejected if the
destination account has a non-zero nonce, non-empty runtime code, or
**non-empty storage**.
After EIP-161, all newly deployed contracts are initialized with a nonce
of one. As a result, such accounts are no longer eligible as deployment
targets unless they are explicitly cleared.
However, prior to EIP-161, contracts were initialized with a nonce of
zero. This made it possible to end up with accounts that have:
- zero nonce
- empty runtime code
- non-empty storage (created during constructor execution)
- non-zero balance
These edge-case accounts complicate the storage emptiness check.
In practice, contract addresses are derived using one of the following
formulas:
- `Keccak256(rlp({sender, nonce}))[12:]`
- `Keccak256([]byte{0xff}, sender, salt[:], initHash)[12:]`
As such, an existing address is not selected as a deployment target
unless a collision occurs, which is extremely unlikely.
---
Previously, verifying storage emptiness relied on GetStorageRoot.
However, with the transition to the block-based access list (BAL),
the storage root is no longer available, as computing it would require
reconstructing the full storage trie from all mutations of preceding
transactions.
To address this, this PR introduces a simplified approach: it hardcodes
the set of known accounts that have zero nonce, empty runtime code,
but non-empty storage and non-zero balance. During contract deployment,
if the destination address belongs to this set, the deployment is
rejected.
This check is applied retroactively back to genesis. Since no address
collision events have occurred in Ethereum’s history, this change does
not
alter existing behavior. Instead, it serves as a safeguard for future
state
transitions.
127 lines
5 KiB
Go
127 lines
5 KiB
Go
// Copyright 2015 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package tests
|
|
|
|
import (
|
|
"math/rand"
|
|
"testing"
|
|
|
|
"github.com/ethereum/go-ethereum/common"
|
|
"github.com/ethereum/go-ethereum/core/rawdb"
|
|
)
|
|
|
|
func TestBlockchain(t *testing.T) {
|
|
bt := new(testMatcher)
|
|
|
|
// We are running most of GeneralStatetests to tests witness support, even
|
|
// though they are ran as state tests too. Still, the performance tests are
|
|
// less about state andmore about EVM number crunching, so skip those.
|
|
bt.skipLoad(`^GeneralStateTests/VMTests/vmPerformance`)
|
|
|
|
// Skip random failures due to selfish mining test
|
|
bt.skipLoad(`.*bcForgedTest/bcForkUncle\.json`)
|
|
|
|
// Slow tests
|
|
bt.slow(`.*bcExploitTest/DelegateCallSpam.json`)
|
|
bt.slow(`.*bcExploitTest/ShanghaiLove.json`)
|
|
bt.slow(`.*bcExploitTest/SuicideIssue.json`)
|
|
bt.slow(`.*/bcForkStressTest/`)
|
|
bt.slow(`.*/bcGasPricerTest/RPC_API_Test.json`)
|
|
bt.slow(`.*/bcWalletTest/`)
|
|
|
|
// Very slow test
|
|
bt.skipLoad(`.*/stTimeConsuming/.*`)
|
|
// test takes a lot for time and goes easily OOM because of sha3 calculation on a huge range,
|
|
// using 4.6 TGas
|
|
bt.skipLoad(`.*randomStatetest94.json.*`)
|
|
|
|
// After the merge we would accept side chains as canonical even if they have lower td
|
|
bt.skipLoad(`.*bcMultiChainTest/ChainAtoChainB_difficultyB.json`)
|
|
bt.skipLoad(`.*bcMultiChainTest/CallContractFromNotBestBlock.json`)
|
|
bt.skipLoad(`.*bcTotalDifficultyTest/uncleBlockAtBlock3afterBlock4.json`)
|
|
bt.skipLoad(`.*bcTotalDifficultyTest/lotsOfBranchesOverrideAtTheMiddle.json`)
|
|
bt.skipLoad(`.*bcTotalDifficultyTest/sideChainWithMoreTransactions.json`)
|
|
bt.skipLoad(`.*bcForkStressTest/ForkStressTest.json`)
|
|
bt.skipLoad(`.*bcMultiChainTest/lotsOfLeafs.json`)
|
|
bt.skipLoad(`.*bcFrontierToHomestead/blockChainFrontierWithLargerTDvsHomesteadBlockchain.json`)
|
|
bt.skipLoad(`.*bcFrontierToHomestead/blockChainFrontierWithLargerTDvsHomesteadBlockchain2.json`)
|
|
|
|
// With chain history removal, TDs become unavailable, this transition tests based on TTD are unrunnable
|
|
bt.skipLoad(`.*bcArrowGlacierToParis/powToPosBlockRejection.json`)
|
|
|
|
// This directory contains no test.
|
|
bt.skipLoad(`.*\.meta/.*`)
|
|
|
|
// Broken tests
|
|
bt.skipLoad(`RevertInCreateInInit`)
|
|
bt.skipLoad(`InitCollisionParis`)
|
|
bt.skipLoad(`dynamicAccountOverwriteEmpty_Paris`)
|
|
bt.skipLoad(`create2collisionStorageParis`)
|
|
|
|
bt.walk(t, blockTestDir, func(t *testing.T, name string, test *BlockTest) {
|
|
execBlockTest(t, bt, test)
|
|
})
|
|
// There is also a LegacyTests folder, containing blockchain tests generated
|
|
// prior to Istanbul. However, they are all derived from GeneralStateTests,
|
|
// which run natively, so there's no reason to run them here.
|
|
}
|
|
|
|
// TestExecutionSpecBlocktests runs the test fixtures from execution-spec-tests.
|
|
func TestExecutionSpecBlocktests(t *testing.T) {
|
|
if !common.FileExist(executionSpecBlockchainTestDir) {
|
|
t.Skipf("directory %s does not exist", executionSpecBlockchainTestDir)
|
|
}
|
|
bt := new(testMatcher)
|
|
|
|
// These tests require us to handle scenarios where a system contract is not deployed at a fork
|
|
bt.skipLoad(".*prague/eip7251_consolidations/test_system_contract_deployment.json")
|
|
bt.skipLoad(".*prague/eip7002_el_triggerable_withdrawals/test_system_contract_deployment.json")
|
|
|
|
// Broken tests
|
|
bt.skipLoad(`RevertInCreateInInit`)
|
|
bt.skipLoad(`InitCollisionParis`)
|
|
bt.skipLoad(`dynamicAccountOverwriteEmpty_Paris`)
|
|
bt.skipLoad(`create2collisionStorageParis`)
|
|
|
|
bt.walk(t, executionSpecBlockchainTestDir, func(t *testing.T, name string, test *BlockTest) {
|
|
execBlockTest(t, bt, test)
|
|
})
|
|
}
|
|
|
|
func execBlockTest(t *testing.T, bt *testMatcher, test *BlockTest) {
|
|
// Define all the different flag combinations we should run the tests with,
|
|
// picking only one for short tests.
|
|
//
|
|
// Note, witness building and self-testing is always enabled as it's a very
|
|
// good test to ensure that we don't break it.
|
|
var (
|
|
snapshotConf = []bool{false, true}
|
|
dbschemeConf = []string{rawdb.HashScheme, rawdb.PathScheme}
|
|
)
|
|
if testing.Short() {
|
|
snapshotConf = []bool{snapshotConf[rand.Int()%2]}
|
|
dbschemeConf = []string{dbschemeConf[rand.Int()%2]}
|
|
}
|
|
for _, snapshot := range snapshotConf {
|
|
for _, dbscheme := range dbschemeConf {
|
|
if err := bt.checkFailure(t, test.Run(snapshot, dbscheme, true, nil, nil)); err != nil {
|
|
t.Errorf("test with config {snapshotter:%v, scheme:%v} failed: %v", snapshot, dbscheme, err)
|
|
return
|
|
}
|
|
}
|
|
}
|
|
}
|