mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-05-23 08:19:27 +00:00
## Summary The `--rpc.telemetry.sample-ratio` flag declares `Value: 1.0` and `geth --help` advertises `(default: 1)`. In practice, however, omitting the flag produces a sample ratio of `0`, causing `sdktrace.TraceIDRatioBased(0)` to drop 100% of spans. Users who enable `--rpc.telemetry` see the `OpenTelemetry trace export enabled` log line and a clean startup, but no traces ever leave the process. The root cause is the interaction between two pieces of code: 1. `cmd/utils/flags.go:setOpenTelemetry` (added in #34062) only copies the flag value when `ctx.IsSet(...)` returns true: ```go if ctx.IsSet(RPCTelemetrySampleRatioFlag.Name) { tcfg.SampleRatio = ctx.Float64(RPCTelemetrySampleRatioFlag.Name) } ``` That is the right pattern for "don't clobber a config-file value with the CLI default," but it implies that something else must initialise the field when neither source sets it. 2. `node/defaults.go:DefaultConfig` never initialises `OpenTelemetry.SampleRatio`, leaving it at the float64 zero value. The result for the common CLI-only user (no TOML config) is `SampleRatio = 0` → every span is silently dropped, despite the documented default of 1. ## Change Seed `OpenTelemetry: OpenTelemetryConfig{SampleRatio: 1.0}` in `node.DefaultConfig` so the documented default matches runtime behavior and the `ctx.IsSet` guard in `setOpenTelemetry` continues to do what it was designed to do.
130 lines
4.4 KiB
Go
130 lines
4.4 KiB
Go
// Copyright 2016 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package node
|
|
|
|
import (
|
|
"os"
|
|
"os/user"
|
|
"path/filepath"
|
|
"runtime"
|
|
|
|
"github.com/ethereum/go-ethereum/common"
|
|
"github.com/ethereum/go-ethereum/p2p"
|
|
"github.com/ethereum/go-ethereum/p2p/nat"
|
|
"github.com/ethereum/go-ethereum/rpc"
|
|
)
|
|
|
|
const (
|
|
DefaultHTTPHost = "localhost" // Default host interface for the HTTP RPC server
|
|
DefaultHTTPPort = 8545 // Default TCP port for the HTTP RPC server
|
|
DefaultWSHost = "localhost" // Default host interface for the websocket RPC server
|
|
DefaultWSPort = 8546 // Default TCP port for the websocket RPC server
|
|
DefaultAuthHost = "localhost" // Default host interface for the authenticated apis
|
|
DefaultAuthPort = 8551 // Default port for the authenticated apis
|
|
)
|
|
|
|
const (
|
|
// Engine API batch limits: these are not configurable by users, and should cover the
|
|
// needs of all CLs.
|
|
engineAPIBatchItemLimit = 2000
|
|
engineAPIBatchResponseSizeLimit = 250 * 1000 * 1000
|
|
engineAPIBodyLimit = 128 * 1024 * 1024
|
|
)
|
|
|
|
var (
|
|
DefaultAuthCors = []string{"localhost"} // Default cors domain for the authenticated apis
|
|
DefaultAuthVhosts = []string{"localhost"} // Default virtual hosts for the authenticated apis
|
|
DefaultAuthOrigins = []string{"localhost"} // Default origins for the authenticated apis
|
|
DefaultAuthPrefix = "" // Default prefix for the authenticated apis
|
|
DefaultAuthModules = []string{"eth", "engine"}
|
|
)
|
|
|
|
// DefaultConfig contains reasonable default settings.
|
|
var DefaultConfig = Config{
|
|
DataDir: DefaultDataDir(),
|
|
HTTPPort: DefaultHTTPPort,
|
|
AuthAddr: DefaultAuthHost,
|
|
AuthPort: DefaultAuthPort,
|
|
AuthVirtualHosts: DefaultAuthVhosts,
|
|
HTTPModules: []string{"net", "web3"},
|
|
HTTPVirtualHosts: []string{"localhost"},
|
|
HTTPTimeouts: rpc.DefaultHTTPTimeouts,
|
|
WSPort: DefaultWSPort,
|
|
WSModules: []string{"net", "web3"},
|
|
BatchRequestLimit: 1000,
|
|
BatchResponseMaxSize: 25 * 1000 * 1000,
|
|
GraphQLVirtualHosts: []string{"localhost"},
|
|
P2P: p2p.Config{
|
|
ListenAddr: ":30303",
|
|
MaxPeers: 50,
|
|
NAT: nat.Any(),
|
|
DiscoveryV4: true,
|
|
DiscoveryV5: true,
|
|
},
|
|
DBEngine: "", // Use whatever exists, will default to Pebble if non-existent and supported
|
|
OpenTelemetry: OpenTelemetryConfig{
|
|
SampleRatio: 1.0,
|
|
},
|
|
}
|
|
|
|
// DefaultDataDir is the default data directory to use for the databases and other
|
|
// persistence requirements.
|
|
func DefaultDataDir() string {
|
|
// Try to place the data folder in the user's home dir
|
|
home := homeDir()
|
|
if home != "" {
|
|
switch runtime.GOOS {
|
|
case "darwin":
|
|
return filepath.Join(home, "Library", "Ethereum")
|
|
case "windows":
|
|
// We used to put everything in %HOME%\AppData\Roaming, but this caused
|
|
// problems with non-typical setups. If this fallback location exists and
|
|
// is non-empty, use it, otherwise DTRT and check %LOCALAPPDATA%.
|
|
fallback := filepath.Join(home, "AppData", "Roaming", "Ethereum")
|
|
appdata := windowsAppData()
|
|
if appdata == "" || common.IsNonEmptyDir(fallback) {
|
|
return fallback
|
|
}
|
|
return filepath.Join(appdata, "Ethereum")
|
|
default:
|
|
return filepath.Join(home, ".ethereum")
|
|
}
|
|
}
|
|
// As we cannot guess a stable location, return empty and handle later
|
|
return ""
|
|
}
|
|
|
|
func windowsAppData() string {
|
|
v := os.Getenv("LOCALAPPDATA")
|
|
if v == "" {
|
|
// Windows XP and below don't have LocalAppData. Crash here because
|
|
// we don't support Windows XP and undefining the variable will cause
|
|
// other issues.
|
|
panic("environment variable LocalAppData is undefined")
|
|
}
|
|
return v
|
|
}
|
|
|
|
func homeDir() string {
|
|
if home := os.Getenv("HOME"); home != "" {
|
|
return home
|
|
}
|
|
if usr, err := user.Current(); err == nil {
|
|
return usr.HomeDir
|
|
}
|
|
return ""
|
|
}
|