mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-06-20 05:41:35 +00:00
dc7e27aff4
## Why this should be merged The `types.Header` fields of both [`coreth`](https://pkg.go.dev/github.com/ava-labs/coreth/core/types#Header) and [`subnet-evm`](https://pkg.go.dev/github.com/ava-labs/subnet-evm/core/types#Header) have been modified such that their RLP encodings (i.e. block hashes) aren't compatible with vanilla `geth` nor each other. This PR adds support for arbitrary RLP encoding coupled with type-safe extra payloads. ## How this works Equivalent to #1 (`params`) and #44 (`types.StateAccount`) registration of pseudo-generic payloads. The only major difference is the guarantee of a non-nil payload pointer, which means that the payload hooks are never called on nil pointers as this would make it difficult to decode RLP into them. ## How this was tested Round-trip RLP {en,de}coding via a registered stub hook. --------- Signed-off-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
79 lines
2.3 KiB
Go
79 lines
2.3 KiB
Go
// Copyright 2024 the libevm authors.
|
|
//
|
|
// The libevm additions to go-ethereum are free software: you can redistribute
|
|
// them and/or modify them under the terms of the GNU Lesser General Public License
|
|
// as published by the Free Software Foundation, either version 3 of the License,
|
|
// or (at your option) any later version.
|
|
//
|
|
// The libevm additions are distributed in the hope that they will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser
|
|
// General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see
|
|
// <http://www.gnu.org/licenses/>.
|
|
|
|
package state
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/ava-labs/libevm/common"
|
|
"github.com/ava-labs/libevm/core/types"
|
|
)
|
|
|
|
func TestStateObjectEmpty(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
registerAndSet func(*types.StateAccount)
|
|
wantEmpty bool
|
|
}{
|
|
{
|
|
name: "no registered types.StateAccount extra payload",
|
|
registerAndSet: func(*types.StateAccount) {},
|
|
wantEmpty: true,
|
|
},
|
|
{
|
|
name: "erroneously non-nil types.StateAccountExtra when no registered payload",
|
|
registerAndSet: func(acc *types.StateAccount) {
|
|
acc.Extra = &types.StateAccountExtra{}
|
|
},
|
|
wantEmpty: true,
|
|
},
|
|
{
|
|
name: "explicit false bool",
|
|
registerAndSet: func(acc *types.StateAccount) {
|
|
types.RegisterExtras[types.NOOPHeaderHooks, *types.NOOPHeaderHooks, bool]().StateAccount.Set(acc, false)
|
|
},
|
|
wantEmpty: true,
|
|
},
|
|
{
|
|
name: "implicit false bool",
|
|
registerAndSet: func(*types.StateAccount) {
|
|
types.RegisterExtras[types.NOOPHeaderHooks, *types.NOOPHeaderHooks, bool]()
|
|
},
|
|
wantEmpty: true,
|
|
},
|
|
{
|
|
name: "true bool",
|
|
registerAndSet: func(acc *types.StateAccount) {
|
|
types.RegisterExtras[types.NOOPHeaderHooks, *types.NOOPHeaderHooks, bool]().StateAccount.Set(acc, true)
|
|
},
|
|
wantEmpty: false,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
types.TestOnlyClearRegisteredExtras()
|
|
t.Cleanup(types.TestOnlyClearRegisteredExtras)
|
|
|
|
obj := newObject(nil, common.Address{}, nil)
|
|
tt.registerAndSet(&obj.data)
|
|
require.Equalf(t, tt.wantEmpty, obj.empty(), "%T.empty()", obj)
|
|
})
|
|
}
|
|
}
|