mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-04-15 22:28:35 +00:00
This PR simplifies the implementation of EIP-7610 by eliminating the
need to check storage emptiness during contract deployment.
EIP-7610 specifies that contract creation must be rejected if the
destination account has a non-zero nonce, non-empty runtime code, or
**non-empty storage**.
After EIP-161, all newly deployed contracts are initialized with a nonce
of one. As a result, such accounts are no longer eligible as deployment
targets unless they are explicitly cleared.
However, prior to EIP-161, contracts were initialized with a nonce of
zero. This made it possible to end up with accounts that have:
- zero nonce
- empty runtime code
- non-empty storage (created during constructor execution)
- non-zero balance
These edge-case accounts complicate the storage emptiness check.
In practice, contract addresses are derived using one of the following
formulas:
- `Keccak256(rlp({sender, nonce}))[12:]`
- `Keccak256([]byte{0xff}, sender, salt[:], initHash)[12:]`
As such, an existing address is not selected as a deployment target
unless a collision occurs, which is extremely unlikely.
---
Previously, verifying storage emptiness relied on GetStorageRoot.
However, with the transition to the block-based access list (BAL),
the storage root is no longer available, as computing it would require
reconstructing the full storage trie from all mutations of preceding
transactions.
To address this, this PR introduces a simplified approach: it hardcodes
the set of known accounts that have zero nonce, empty runtime code,
but non-empty storage and non-zero balance. During contract deployment,
if the destination address belongs to this set, the deployment is
rejected.
This check is applied retroactively back to genesis. Since no address
collision events have occurred in Ethereum’s history, this change does
not
alter existing behavior. Instead, it serves as a safeguard for future
state
transitions.
351 lines
10 KiB
Go
351 lines
10 KiB
Go
// Copyright 2015 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package tests
|
|
|
|
import (
|
|
"bufio"
|
|
"bytes"
|
|
"fmt"
|
|
"math/big"
|
|
"math/rand"
|
|
"os"
|
|
"path/filepath"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/ethereum/go-ethereum/common"
|
|
"github.com/ethereum/go-ethereum/core"
|
|
"github.com/ethereum/go-ethereum/core/rawdb"
|
|
"github.com/ethereum/go-ethereum/core/types"
|
|
"github.com/ethereum/go-ethereum/core/vm"
|
|
"github.com/ethereum/go-ethereum/eth/tracers/logger"
|
|
"github.com/holiman/uint256"
|
|
)
|
|
|
|
func initMatcher(st *testMatcher) {
|
|
// Long tests:
|
|
st.slow(`^stAttackTest/ContractCreationSpam`)
|
|
st.slow(`^stBadOpcode/badOpcodes`)
|
|
st.slow(`^stPreCompiledContracts/modexp`)
|
|
st.slow(`^stQuadraticComplexityTest/`)
|
|
st.slow(`^stStaticCall/static_Call50000`)
|
|
st.slow(`^stStaticCall/static_Return50000`)
|
|
st.slow(`^stSystemOperationsTest/CallRecursiveBomb`)
|
|
st.slow(`^stTransactionTest/Opcodes_TransactionInit`)
|
|
// Very time consuming
|
|
st.skipLoad(`^stTimeConsuming/`)
|
|
st.skipLoad(`.*vmPerformance/loop.*`)
|
|
// Uses 1GB RAM per tested fork
|
|
st.skipLoad(`^stStaticCall/static_Call1MB`)
|
|
|
|
// Broken tests:
|
|
// EOF is not part of cancun
|
|
st.skipLoad(`^stEOF/`)
|
|
|
|
st.skipLoad(`RevertInCreateInInit`)
|
|
st.skipLoad(`InitCollisionParis`)
|
|
st.skipLoad(`dynamicAccountOverwriteEmpty_Paris`)
|
|
st.skipLoad(`create2collisionStorageParis`)
|
|
}
|
|
|
|
func TestState(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
st := new(testMatcher)
|
|
initMatcher(st)
|
|
for _, dir := range []string{
|
|
filepath.Join(baseDir, "EIPTests", "StateTests"),
|
|
stateTestDir,
|
|
benchmarksDir,
|
|
} {
|
|
st.walk(t, dir, func(t *testing.T, name string, test *StateTest) {
|
|
execStateTest(t, st, test)
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestLegacyState tests some older tests, which were moved to the folder
|
|
// 'LegacyTests' for the Istanbul fork.
|
|
func TestLegacyState(t *testing.T) {
|
|
st := new(testMatcher)
|
|
initMatcher(st)
|
|
st.walk(t, legacyStateTestDir, func(t *testing.T, name string, test *StateTest) {
|
|
execStateTest(t, st, test)
|
|
})
|
|
}
|
|
|
|
// TestExecutionSpecState runs the test fixtures from execution-spec-tests.
|
|
func TestExecutionSpecState(t *testing.T) {
|
|
if !common.FileExist(executionSpecStateTestDir) {
|
|
t.Skipf("directory %s does not exist", executionSpecStateTestDir)
|
|
}
|
|
st := new(testMatcher)
|
|
|
|
// Broken tests
|
|
st.skipLoad(`RevertInCreateInInit`)
|
|
st.skipLoad(`InitCollisionParis`)
|
|
st.skipLoad(`dynamicAccountOverwriteEmpty_Paris`)
|
|
st.skipLoad(`create2collisionStorageParis`)
|
|
|
|
st.walk(t, executionSpecStateTestDir, func(t *testing.T, name string, test *StateTest) {
|
|
execStateTest(t, st, test)
|
|
})
|
|
}
|
|
|
|
func execStateTest(t *testing.T, st *testMatcher, test *StateTest) {
|
|
for _, subtest := range test.Subtests() {
|
|
key := fmt.Sprintf("%s/%d", subtest.Fork, subtest.Index)
|
|
|
|
// If -short flag is used, we don't execute all four permutations, only
|
|
// one.
|
|
executionMask := 0xf
|
|
if testing.Short() {
|
|
executionMask = (1 << (rand.Int63() & 4))
|
|
}
|
|
t.Run(key+"/hash/trie", func(t *testing.T) {
|
|
if executionMask&0x1 == 0 {
|
|
t.Skip("test (randomly) skipped due to short-tag")
|
|
}
|
|
withTrace(t, test.gasLimit(subtest), func(vmconfig vm.Config) error {
|
|
var result error
|
|
test.Run(subtest, vmconfig, false, rawdb.HashScheme, func(err error, state *StateTestState) {
|
|
result = st.checkFailure(t, err)
|
|
})
|
|
return result
|
|
})
|
|
})
|
|
t.Run(key+"/hash/snap", func(t *testing.T) {
|
|
if executionMask&0x2 == 0 {
|
|
t.Skip("test (randomly) skipped due to short-tag")
|
|
}
|
|
withTrace(t, test.gasLimit(subtest), func(vmconfig vm.Config) error {
|
|
var result error
|
|
test.Run(subtest, vmconfig, true, rawdb.HashScheme, func(err error, state *StateTestState) {
|
|
if state.Snapshots != nil && state.StateDB != nil {
|
|
if _, err := state.Snapshots.Journal(state.StateDB.IntermediateRoot(false)); err != nil {
|
|
result = err
|
|
return
|
|
}
|
|
}
|
|
result = st.checkFailure(t, err)
|
|
})
|
|
return result
|
|
})
|
|
})
|
|
t.Run(key+"/path/trie", func(t *testing.T) {
|
|
if executionMask&0x4 == 0 {
|
|
t.Skip("test (randomly) skipped due to short-tag")
|
|
}
|
|
withTrace(t, test.gasLimit(subtest), func(vmconfig vm.Config) error {
|
|
var result error
|
|
test.Run(subtest, vmconfig, false, rawdb.PathScheme, func(err error, state *StateTestState) {
|
|
result = st.checkFailure(t, err)
|
|
})
|
|
return result
|
|
})
|
|
})
|
|
t.Run(key+"/path/snap", func(t *testing.T) {
|
|
if executionMask&0x8 == 0 {
|
|
t.Skip("test (randomly) skipped due to short-tag")
|
|
}
|
|
withTrace(t, test.gasLimit(subtest), func(vmconfig vm.Config) error {
|
|
var result error
|
|
test.Run(subtest, vmconfig, true, rawdb.PathScheme, func(err error, state *StateTestState) {
|
|
if state.TrieDB != nil && state.StateDB != nil {
|
|
if err := state.TrieDB.Journal(state.StateDB.IntermediateRoot(false)); err != nil {
|
|
result = err
|
|
return
|
|
}
|
|
}
|
|
result = st.checkFailure(t, err)
|
|
})
|
|
return result
|
|
})
|
|
})
|
|
}
|
|
}
|
|
|
|
// Transactions with gasLimit above this value will not get a VM trace on failure.
|
|
const traceErrorLimit = 400000
|
|
|
|
func withTrace(t *testing.T, gasLimit uint64, test func(vm.Config) error) {
|
|
// Use config from command line arguments.
|
|
config := vm.Config{}
|
|
err := test(config)
|
|
if err == nil {
|
|
return
|
|
}
|
|
|
|
// Test failed, re-run with tracing enabled.
|
|
t.Error(err)
|
|
if gasLimit > traceErrorLimit {
|
|
t.Log("gas limit too high for EVM trace")
|
|
return
|
|
}
|
|
buf := new(bytes.Buffer)
|
|
w := bufio.NewWriter(buf)
|
|
config.Tracer = logger.NewJSONLogger(&logger.Config{}, w)
|
|
err2 := test(config)
|
|
if !reflect.DeepEqual(err, err2) {
|
|
t.Errorf("different error for second run: %v", err2)
|
|
}
|
|
w.Flush()
|
|
if buf.Len() == 0 {
|
|
t.Log("no EVM operation logs generated")
|
|
} else {
|
|
t.Log("EVM operation log:\n" + buf.String())
|
|
}
|
|
// t.Logf("EVM output: 0x%x", tracer.Output())
|
|
// t.Logf("EVM error: %v", tracer.Error())
|
|
}
|
|
|
|
func BenchmarkEVM(b *testing.B) {
|
|
// Walk the directory.
|
|
dir := benchmarksDir
|
|
dirinfo, err := os.Stat(dir)
|
|
if os.IsNotExist(err) || !dirinfo.IsDir() {
|
|
fmt.Fprintf(os.Stderr, "can't find test files in %s, did you clone the evm-benchmarks submodule?\n", dir)
|
|
b.Skip("missing test files")
|
|
}
|
|
err = filepath.Walk(dir, func(path string, info os.FileInfo, err error) error {
|
|
if info.IsDir() {
|
|
return nil
|
|
}
|
|
if ext := filepath.Ext(path); ext == ".json" {
|
|
name := filepath.ToSlash(strings.TrimPrefix(strings.TrimSuffix(path, ext), dir+string(filepath.Separator)))
|
|
b.Run(name, func(b *testing.B) { runBenchmarkFile(b, path) })
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func runBenchmarkFile(b *testing.B, path string) {
|
|
m := make(map[string]StateTest)
|
|
if err := readJSONFile(path, &m); err != nil {
|
|
b.Fatal(err)
|
|
return
|
|
}
|
|
if len(m) != 1 {
|
|
b.Fatal("expected single benchmark in a file")
|
|
return
|
|
}
|
|
for _, t := range m {
|
|
runBenchmark(b, &t)
|
|
}
|
|
}
|
|
|
|
func runBenchmark(b *testing.B, t *StateTest) {
|
|
for _, subtest := range t.Subtests() {
|
|
key := fmt.Sprintf("%s/%d", subtest.Fork, subtest.Index)
|
|
|
|
b.Run(key, func(b *testing.B) {
|
|
vmconfig := vm.Config{}
|
|
|
|
config, eips, err := GetChainConfig(subtest.Fork)
|
|
if err != nil {
|
|
b.Error(err)
|
|
return
|
|
}
|
|
var rules = config.Rules(new(big.Int), false, 0)
|
|
|
|
vmconfig.ExtraEips = eips
|
|
block := t.genesis(config).ToBlock()
|
|
state := MakePreState(rawdb.NewMemoryDatabase(), t.json.Pre, false, rawdb.HashScheme)
|
|
defer state.Close()
|
|
|
|
var baseFee *big.Int
|
|
if rules.IsLondon {
|
|
baseFee = t.json.Env.BaseFee
|
|
if baseFee == nil {
|
|
// Retesteth uses `0x10` for genesis baseFee. Therefore, it defaults to
|
|
// parent - 2 : 0xa as the basefee for 'this' context.
|
|
baseFee = big.NewInt(0x0a)
|
|
}
|
|
}
|
|
post := t.json.Post[subtest.Fork][subtest.Index]
|
|
msg, err := t.json.Tx.toMessage(post, baseFee)
|
|
if err != nil {
|
|
b.Error(err)
|
|
return
|
|
}
|
|
|
|
// Try to recover tx with current signer
|
|
if len(post.TxBytes) != 0 {
|
|
var ttx types.Transaction
|
|
err := ttx.UnmarshalBinary(post.TxBytes)
|
|
if err != nil {
|
|
b.Error(err)
|
|
return
|
|
}
|
|
|
|
if _, err := types.Sender(types.LatestSigner(config), &ttx); err != nil {
|
|
b.Error(err)
|
|
return
|
|
}
|
|
}
|
|
|
|
// Prepare the EVM.
|
|
txContext := core.NewEVMTxContext(msg)
|
|
context := core.NewEVMBlockContext(block.Header(), &dummyChain{config: config}, &t.json.Env.Coinbase)
|
|
context.GetHash = vmTestBlockHash
|
|
context.BaseFee = baseFee
|
|
evm := vm.NewEVM(context, state.StateDB, config, vmconfig)
|
|
evm.SetTxContext(txContext)
|
|
|
|
// Create "contract" for sender to cache code analysis.
|
|
sender := vm.NewContract(msg.From, msg.From, nil, 0, nil)
|
|
|
|
var (
|
|
gasUsed uint64
|
|
elapsed uint64
|
|
refund uint64
|
|
)
|
|
b.ResetTimer()
|
|
for n := 0; n < b.N; n++ {
|
|
snapshot := state.StateDB.Snapshot()
|
|
state.StateDB.Prepare(rules, msg.From, context.Coinbase, msg.To, vm.ActivePrecompiles(rules), msg.AccessList)
|
|
b.StartTimer()
|
|
start := time.Now()
|
|
|
|
// Execute the message.
|
|
_, leftOverGas, err := evm.Call(sender.Address(), *msg.To, msg.Data, msg.GasLimit, uint256.MustFromBig(msg.Value))
|
|
if err != nil {
|
|
b.Error(err)
|
|
return
|
|
}
|
|
|
|
b.StopTimer()
|
|
elapsed += uint64(time.Since(start))
|
|
refund += state.StateDB.GetRefund()
|
|
gasUsed += msg.GasLimit - leftOverGas
|
|
|
|
state.StateDB.RevertToSnapshot(snapshot)
|
|
}
|
|
if elapsed < 1 {
|
|
elapsed = 1
|
|
}
|
|
// Keep it as uint64, multiply 100 to get two digit float later
|
|
mgasps := (100 * 1000 * (gasUsed - refund)) / elapsed
|
|
b.ReportMetric(float64(mgasps)/100, "mgas/s")
|
|
})
|
|
}
|
|
}
|