mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-02-26 15:47:21 +00:00
d2bbde2f2d
This ensures that if we receive a blob transaction announcement where we cannot link the tx to the sidecar commitments, we will drop the sending peer. This check is added in the protocol handler for the PooledTransactions message. Tests for this have also been added in the cross-client "eth" protocol test suite. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
90 lines
3.2 KiB
Go
90 lines
3.2 KiB
Go
// Copyright 2020 The go-ethereum Authors
|
|
// This file is part of the go-ethereum library.
|
|
//
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Lesser General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Lesser General Public License
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package eth
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/ethereum/go-ethereum/core"
|
|
"github.com/ethereum/go-ethereum/core/types"
|
|
"github.com/ethereum/go-ethereum/eth/protocols/eth"
|
|
"github.com/ethereum/go-ethereum/p2p/enode"
|
|
)
|
|
|
|
// ethHandler implements the eth.Backend interface to handle the various network
|
|
// packets that are sent as replies or broadcasts.
|
|
type ethHandler handler
|
|
|
|
func (h *ethHandler) Chain() *core.BlockChain { return h.chain }
|
|
func (h *ethHandler) TxPool() eth.TxPool { return h.txpool }
|
|
|
|
// RunPeer is invoked when a peer joins on the `eth` protocol.
|
|
func (h *ethHandler) RunPeer(peer *eth.Peer, hand eth.Handler) error {
|
|
return (*handler)(h).runEthPeer(peer, hand)
|
|
}
|
|
|
|
// PeerInfo retrieves all known `eth` information about a peer.
|
|
func (h *ethHandler) PeerInfo(id enode.ID) interface{} {
|
|
if p := h.peers.peer(id.String()); p != nil {
|
|
return p.info()
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// AcceptTxs retrieves whether transaction processing is enabled on the node
|
|
// or if inbound transactions should simply be dropped.
|
|
func (h *ethHandler) AcceptTxs() bool {
|
|
return h.synced.Load()
|
|
}
|
|
|
|
// Handle is invoked from a peer's message handler when it receives a new remote
|
|
// message that the handler couldn't consume and serve itself.
|
|
func (h *ethHandler) Handle(peer *eth.Peer, packet eth.Packet) error {
|
|
// Consume any broadcasts and announces, forwarding the rest to the downloader
|
|
switch packet := packet.(type) {
|
|
case *eth.NewPooledTransactionHashesPacket:
|
|
return h.txFetcher.Notify(peer.ID(), packet.Types, packet.Sizes, packet.Hashes)
|
|
|
|
case *eth.TransactionsPacket:
|
|
for _, tx := range *packet {
|
|
if tx.Type() == types.BlobTxType {
|
|
return errors.New("disallowed broadcast blob transaction")
|
|
}
|
|
}
|
|
return h.txFetcher.Enqueue(peer.ID(), *packet, false)
|
|
|
|
case *eth.PooledTransactionsResponse:
|
|
// If we receive any blob transactions missing sidecars, or with
|
|
// sidecars that don't correspond to the versioned hashes reported
|
|
// in the header, disconnect from the sending peer.
|
|
for _, tx := range *packet {
|
|
if tx.Type() == types.BlobTxType {
|
|
if tx.BlobTxSidecar() == nil {
|
|
return errors.New("received sidecar-less blob transaction")
|
|
}
|
|
if err := tx.BlobTxSidecar().ValidateBlobCommitmentHashes(tx.BlobHashes()); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
return h.txFetcher.Enqueue(peer.ID(), *packet, true)
|
|
|
|
default:
|
|
return fmt.Errorf("unexpected eth packet type: %T", packet)
|
|
}
|
|
}
|