mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-07-23 21:26:42 +00:00
remove outdated todos
This commit is contained in:
parent
c841457587
commit
4bc885e809
4 changed files with 3 additions and 13 deletions
|
|
@ -1499,7 +1499,7 @@ func (p *BlobPool) ValidateTxBasics(tx *types.Transaction) error {
|
|||
Accept: 1 << types.BlobTxType,
|
||||
MaxSize: txMaxSize,
|
||||
MinTip: p.gasTip.Load().ToBig(),
|
||||
MaxBlobCount: maxBlobsPerTx, //todo this field is currently not being used
|
||||
MaxBlobCount: maxBlobsPerTx,
|
||||
}
|
||||
return txpool.ValidateTransaction(tx, p.head.Load(), p.signer, opts)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -32,7 +32,6 @@ import (
|
|||
"github.com/ethereum/go-ethereum/metrics"
|
||||
)
|
||||
|
||||
// todo: per-peer size limit
|
||||
var (
|
||||
blobBufferTxFirstCounter = metrics.NewRegisteredCounter("blobpool/buffer/txfirst", nil)
|
||||
blobBufferCellsFirstCounter = metrics.NewRegisteredCounter("blobpool/buffer/cellsfirst", nil)
|
||||
|
|
|
|||
|
|
@ -28,8 +28,6 @@ import (
|
|||
"github.com/ethereum/go-ethereum/crypto/kzg4844"
|
||||
)
|
||||
|
||||
// todo remove partial / full
|
||||
|
||||
type random interface {
|
||||
Intn(n int) int
|
||||
}
|
||||
|
|
@ -39,8 +37,6 @@ type random interface {
|
|||
// For availability checks, it fetches cells from each blob in the transaction
|
||||
// according to the custody cell indices provided by the consensus client
|
||||
// connected to this execution client.
|
||||
|
||||
// todo
|
||||
var blobFetchTimeout = 5 * time.Second
|
||||
var blobAvailabilityTimeout = 2 * time.Second
|
||||
|
||||
|
|
@ -138,9 +134,8 @@ type BlobFetcher struct {
|
|||
|
||||
// Buffer 2
|
||||
// Stage 3: Transactions whose payloads/cells are currently being fetched (full fetch + partial fetch)
|
||||
fetches map[common.Hash]*fetchStatus // Hash -> Bitmap, in-flight transaction cells
|
||||
requests map[string][]*cellRequest // In-flight transaction retrievals
|
||||
// todo simplify
|
||||
fetches map[common.Hash]*fetchStatus // Hash -> Bitmap, in-flight transaction cells
|
||||
requests map[string][]*cellRequest // In-flight transaction retrievals
|
||||
alternates map[common.Hash]map[string]*types.CustodyBitmap // In-flight transaction alternate origins (in case the peer is dropped)
|
||||
|
||||
fn BlobFetcherFunctions // callbacks
|
||||
|
|
|
|||
|
|
@ -330,9 +330,6 @@ func TestBlobFetcherPartialFetch(t *testing.T) {
|
|||
})
|
||||
}
|
||||
|
||||
// todo wait timeout
|
||||
// todo drop
|
||||
|
||||
// TestBlobFetcherFullDelivery tests cell delivery and fetch completion logic (full fetch)
|
||||
func TestBlobFetcherFullDelivery(t *testing.T) {
|
||||
testBlobFetcher(t, blobFetcherTest{
|
||||
|
|
@ -809,7 +806,6 @@ func testBlobFetcher(t *testing.T, tt blobFetcherTest) {
|
|||
}
|
||||
|
||||
case isBlobScheduled:
|
||||
// todo fetches
|
||||
// Check tracking (announces) - bidirectional verification
|
||||
for peer, announces := range step.announces {
|
||||
peerAnnounces := fetcher.announces[peer]
|
||||
|
|
|
|||
Loading…
Reference in a new issue