forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-23 13:16:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

add TODO not to investigate weird behavior and unexpected test failure

Browse source
This commit is contained in:
Jared Wasinger 2025-10-05 16:05:21 +08:00
parent 047b2569f6
commit 75bfcf27a9
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/blockchain.go
View file

@ -2156,9 +2156,13 @@ func (bc *BlockChain) ProcessBlock(parentRoot common.Hash, block *types.Block, s
} }
ptime = time.Since(pstart) ptime = time.Since(pstart)
// TODO: if I remove this check before executing balTracer.Finalise, the following test fails:
// ExecutionSpecBlocktests/shanghai/eip3855_push0/push0/push0_storage_overwrite.json
if constructBALForTesting {
// TODO: remove. gross. shouldn't have to manually call Finalise // TODO: remove. gross. shouldn't have to manually call Finalise
// to pull in post-tx-execution state changes to the BAL here. // to pull in post-tx-execution state changes to the BAL here.
balTracer.Finalise() balTracer.Finalise()
}
// unset the BAL-creation tracer (dirty) // unset the BAL-creation tracer (dirty)
bc.cfg.VmConfig.Tracer = nil bc.cfg.VmConfig.Tracer = nil