forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-27 07:06:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

DEVOPS-829 fix complaints from linter

Browse source
This commit is contained in:
Will Button 2023-05-31 15:37:35 -07:00
parent c9e77eb445
commit 9c1b90591f
No known key found for this signature in database
GPG key ID: EBA4422D1CA5F162
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
metrics/prometheus/collector.go
View file

@ -62,12 +62,14 @@ func (c *collector) addGaugeFloat64(name string, m metrics.GaugeFloat64) {
func (c *collector) addHistogram(name string, m metrics.Histogram) { func (c *collector) addHistogram(name string, m metrics.Histogram) {
pv := []float64{0.5, 0.75, 0.95, 0.99, 0.999, 0.9999} pv := []float64{0.5, 0.75, 0.95, 0.99, 0.999, 0.9999}
ps := m.Percentiles(pv) ps := m.Percentiles(pv)
var sum float64 = 0 var sum float64 = 0
c.buff.WriteString(fmt.Sprintf(typeSummaryTpl, mutateKey(name))) c.buff.WriteString(fmt.Sprintf(typeSummaryTpl, mutateKey(name)))
for i := range pv { for i := range pv {
c.writeSummaryPercentile(name, strconv.FormatFloat(pv[i], 'f', -1, 64), ps[i]) c.writeSummaryPercentile(name, strconv.FormatFloat(pv[i], 'f', -1, 64), ps[i])
sum += ps[i] sum += ps[i]
} }
c.writeSummarySum(name, fmt.Sprintf("%f", sum)) c.writeSummarySum(name, fmt.Sprintf("%f", sum))
c.writeSummaryCounter(name, len(ps)) c.writeSummaryCounter(name, len(ps))
c.buff.WriteRune('\n') c.buff.WriteRune('\n')
@ -98,10 +100,13 @@ func (c *collector) addResettingTimer(name string, m metrics.ResettingTimer) {
c.writeSummaryPercentile(name, "0.50", ps[0]) c.writeSummaryPercentile(name, "0.50", ps[0])
c.writeSummaryPercentile(name, "0.95", ps[1]) c.writeSummaryPercentile(name, "0.95", ps[1])
c.writeSummaryPercentile(name, "0.99", ps[2]) c.writeSummaryPercentile(name, "0.99", ps[2])
var sum int64 = 0 var sum int64 = 0
for _, v := range val { for _, v := range val {
sum += v sum += v
} }
c.writeSummarySum(name, fmt.Sprintf("%d", sum)) c.writeSummarySum(name, fmt.Sprintf("%d", sum))
c.writeSummaryCounter(name, len(val)) c.writeSummaryCounter(name, len(val))
c.buff.WriteRune('\n') c.buff.WriteRune('\n')

1
metrics/prometheus/collector_test.go
View file

@ -99,6 +99,7 @@ test_resetting_timer_sum 180000000
test_resetting_timer_count 6 test_resetting_timer_count 6
` `
c.addResettingTimer("test/empty_resetting_timer", emptyResettingTimer) c.addResettingTimer("test/empty_resetting_timer", emptyResettingTimer)
exp := c.buff.String() exp := c.buff.String()