forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-08-20 10:52:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

resolve reviews

Browse source
This commit is contained in:
bnovil 2023-10-04 21:42:52 +08:00
parent 605623a58a
commit bd6fc4ea6a
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ethclient/gethclient/gethclient.go
View file

@ -246,9 +246,9 @@ func (ec *Client) TraceBlock(ctx context.Context, blob []byte, config *tracers.T
}
// TraceBlockByNumber returns the structured logs created during the execution of EVM
func (ec *Client) TraceBlockByNumber(ctx context.Context, number rpc.BlockNumber, config *tracers.TraceConfig) ([]*TxTraceResult, error) {
func (ec *Client) TraceBlockByNumber(ctx context.Context, number *big.Int, config *tracers.TraceConfig) ([]*TxTraceResult, error) {
var result []*TxTraceResult
err := ec.c.CallContext(ctx, &result, "debug_traceBlockByNumber", number, config)
err := ec.c.CallContext(ctx, &result, "debug_traceBlockByNumber", toBlockNumArg(number), config)
return result, err
}

6
ethclient/gethclient/gethclient_test.go
View file

@ -768,19 +768,19 @@ func testTraceBlockByNumber(t *testing.T, client *rpc.Client) {
ec := New(client)
var testSuite = []struct {
blockNumber rpc.BlockNumber
blockNumber *big.Int
config *tracers.TraceConfig
expectErr error
expect []*TxTraceResult
}{
{
blockNumber: 1,
blockNumber: big.NewInt(1),
config: nil,
expectErr: nil,
expect: []*TxTraceResult{{TxHash: testTransactionHash}},
},
{
blockNumber: 1,
blockNumber: big.NewInt(1),
config: &tracers.TraceConfig{
Config: &logger.Config{
EnableMemory: true,