forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-07-15 17:30:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

internal/testlog: clone attributes before appending (#35324)

Browse source 
WithAttrs and terminalFormat appended to h.attrs directly, which can
mutate the shared slice when it has spare capacity. Clone attrs first to
avoid corrupting parent handler state.
This commit is contained in:
cui 2026-07-13 17:06:26 +08:00 committed by GitHub
parent 13bcbf0eef
commit df7b89603c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
internal/testlog/testlog.go
View file

@ -22,6 +22,7 @@ import (
"context"
"fmt"
"log/slog"
"slices"
"sync"
"github.com/ethereum/go-ethereum/log"
@ -76,7 +77,7 @@ func (h *bufHandler) WithAttrs(attrs []slog.Attr) slog.Handler {
copy(records[:], h.buf[:])
return &bufHandler{
buf: records,
attrs: append(h.attrs, attrs...),
attrs: append(slices.Clone(h.attrs), attrs...),
level: h.level,
}
}
@ -186,7 +187,7 @@ func (h *bufHandler) terminalFormat(r slog.Record) string {
return true
})
attrs = append(h.attrs, attrs...)
attrs = append(slices.Clone(h.attrs), attrs...)
fmt.Fprintf(buf, "%s[%s] %s ", lvl, r.Time.Format(termTimeFormat), r.Message)
if length := len(r.Message); length < 40 {