forks/go-ethereum
1
0
Fork 1
mirror of https://github.com/ethereum/go-ethereum.git synced 2026-06-12 01:41:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

trie/bintrie: drop unused freeInternals and freeStems

Browse source 
Only freeHashed is written to (via freeHashedNode); the internal and
stem lists are declared, consumed in alloc paths, and copied in
NodeStore.Copy, but no callsite ever appends to them. Under current
semantics (no delete, stem-split keeps the old stem deeper in the
tree) there is no path that would free an internal or stem slot, so
the recycle branch was dead code. Drop it to avoid misleading future
contributors; the infrastructure is easy to restore if a delete path
is ever added.
This commit is contained in:
CPerezz 2026-04-19 22:15:01 +02:00
parent 99520432ec
commit f8c283410e
No known key found for this signature in database
GPG key ID: 62045F34B97177DD
1 changed files with 5 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
trie/bintrie/node_store.go
View file

@ -36,10 +36,11 @@ type NodeStore struct {
root nodeRef
// Free lists for recycling deleted node slots.
freeInternals []uint32
freeStems []uint32
freeHashed []uint32
// Free list for recycling hashed-node slots after resolve. Internal and
// stem nodes are never freed under current semantics (no delete path,
// stem-split keeps the old stem at a deeper position), so they don't
// have free lists.
freeHashed []uint32
}
func NewNodeStore() *NodeStore {
@ -47,12 +48,6 @@ func NewNodeStore() *NodeStore {
}
func (s *NodeStore) allocInternal() uint32 {
if n := len(s.freeInternals); n > 0 {
idx := s.freeInternals[n-1]
s.freeInternals = s.freeInternals[:n-1]
*s.getInternal(idx) = InternalNode{}
return idx
}
idx := s.internalCount
chunkIdx := idx / storeChunkSize
if uint32(len(s.internalChunks)) <= chunkIdx {
@ -82,12 +77,6 @@ func (s *NodeStore) newInternalRef(depth int) nodeRef {
}
func (s *NodeStore) allocStem() uint32 {
if n := len(s.freeStems); n > 0 {
idx := s.freeStems[n-1]
s.freeStems = s.freeStems[:n-1]
*s.getStem(idx) = StemNode{}
return idx
}
idx := s.stemCount
chunkIdx := idx / storeChunkSize
if uint32(len(s.stemChunks)) <= chunkIdx {
@ -186,14 +175,6 @@ func (s *NodeStore) Copy() *NodeStore {
cp := *chunk
ns.hashedChunks[i] = &cp
}
if len(s.freeInternals) > 0 {
ns.freeInternals = make([]uint32, len(s.freeInternals))
copy(ns.freeInternals, s.freeInternals)
}
if len(s.freeStems) > 0 {
ns.freeStems = make([]uint32, len(s.freeStems))
copy(ns.freeStems, s.freeStems)
}
if len(s.freeHashed) > 0 {
ns.freeHashed = make([]uint32, len(s.freeHashed))
copy(ns.freeHashed, s.freeHashed)