Commit graph

9702 commits

Author SHA1 Message Date
Armin Braun
118a34d561 #15685 made peer_test.go more portable by using random free port instead of hardcoded port 30303 (#15687)
Improves test portability by resolving 127.0.0.1:0
to get a random free port instead of the hard coded one. Now
the test works if you have a running node on the same
interface already.

Fixes #15685
2018-07-09 12:15:46 -07:00
Caesar Chad
21e3288d14 console: correct some comments typo (#16971)
console/console: correct some comments typo
2018-07-09 12:15:46 -07:00
Caesar Chad
a3a88aed72 core/asm: correct comments typo (#16975)
core/asm/lexer: correct comments typo
2018-07-09 12:15:46 -07:00
Wenbiao Zheng
23026ea55a eth/fetcher: fix annotation (#16969) 2018-07-09 12:15:46 -07:00
Ryan Schneider
f69007a5c0 internal/web3ext: fix method name for enabling mutex profiling (#16964) 2018-07-09 12:15:46 -07:00
John C. Vernaleo
c61f46d59b core: change comment to match code more closely (#16963) 2018-07-09 12:15:46 -07:00
Péter Szilágyi
404cd5dd18 VERSION, params: begin v1.8.12 release cycle 2018-07-09 12:15:46 -07:00
Péter Szilágyi
50b172794d params: release go-ethereum v1.8.11 2018-07-09 12:15:46 -07:00
Felföldi Zsolt
82848a8fc9 les: fix retriever logic (#16776)
This PR fixes a retriever logic bug. When a peer had a soft timeout
and then a response arrived, it always assumed it was the same peer
even though it could have been a later requested one that did not time
out at all yet. In this case the logic went to an illegal state and
deadlocked, causing a goroutine leak.

Fixes #16243 and replaces #16359.
Thanks to @riceke for finding the bug in the logic.
2018-07-09 12:15:46 -07:00
Felföldi Zsolt
8671b36089 core, eth, les: more efficient hash-based header chain retrieval (#16946) 2018-07-09 12:15:46 -07:00
Felix Lange
86f75323b2 crypto: replace ToECDSAPub with error-checking func UnmarshalPubkey (#16932)
ToECDSAPub was unsafe because it returned a non-nil key with nil X, Y in
case of invalid input. This change replaces ToECDSAPub with
UnmarshalPubkey across the codebase.
2018-07-09 12:15:46 -07:00
Péter Szilágyi
4944fddcdf internal/ethapi: reduce pendingTransactions to O(txs+accs) from O(txs*accs) 2018-07-09 12:15:46 -07:00
Péter Szilágyi
78009b509f metrics: fix gofmt linter warnings 2018-07-09 12:15:46 -07:00
Felföldi Zsolt
9a48be728e les: pass server pool to protocol manager (#16947) 2018-07-09 12:15:46 -07:00
gary rong
38a57bde25 ethdb: gracefullly handle quit channel (#16794)
* ethdb: gratefullly handle quit channel

* ethdb: minor polish
2018-07-09 12:15:46 -07:00
Wenbiao Zheng
e116db053d core/rawdb: wrap db key creations (#16914)
* core/rawdb: use wrappered helper to assemble key

* core/rawdb: wrappered helper to assemble key

* core/rawdb: rewrite the wrapper, pass common.Hash
2018-07-09 12:15:46 -07:00
Péter Szilágyi
dddac0e850 trie: don't report the root flushlist as an alloc 2018-07-09 12:15:46 -07:00
Clayton Jacobs
2454024da0 metrics: removed repetitive calculations (#16944) 2018-07-09 12:15:46 -07:00
Péter Szilágyi
82641ce8fa rpc: golint fixes 2018-07-09 12:15:32 -07:00
xincaosu
200ad6b979 rpc: fix a comment typo (#16929) 2018-07-09 12:14:48 -07:00
Martin Holst Swende
cac47657f6 core: improve getBadBlocks to return full block rlp (#16902)
* core: improve getBadBlocks to return full block rlp

* core, eth, ethapi: changes to getBadBlocks formatting

* ethapi: address review concerns
2018-07-09 12:14:48 -07:00
Steven Roose
d9a5f91faa ethclient: fix RPC parse error of Parity response (#16924)
The error produced when using a Parity RPC was the following:

ERROR: transaction did not get mined: failed to get tx for txid 0xbdeb094b3278019383c8da148ff1cb5b5dbd61bf8731bc2310ac1b8ed0235226: json: cannot unmarshal non-string into Go struct field txExtraInfo.blockHash of type common.Hash
2018-07-09 12:14:48 -07:00
Felföldi Zsolt
34a102ff13 light: new CHTs for mainnet and ropsten (#16926) 2018-07-09 12:14:48 -07:00
Anton Evangelatov
3f22648968 metrics: return an empty snapshot for NilResettingTimer (#16930) 2018-07-09 12:14:48 -07:00
Steven Roose
084137d825 cmd/ethkey: add command to change key passphrase (#16516)
This change introduces 

    ethkey changepassphrase <keyfile>

to change the passphrase of a key file.
2018-07-09 12:14:48 -07:00
Sarlor
cc1b118b3f trie: avoid unnecessary slicing on shortnode decoding (#16917)
optimization code
2018-07-09 12:14:48 -07:00
ledgerwatch
4add50fd76 core: relax type requirement for bc in ApplyTransaction (#16901) 2018-07-09 12:14:48 -07:00
Bruno Škvorc
2f46a73f9d cmd/puppeth: fixed a typo in a wizard input query (#16910) 2018-07-09 12:14:48 -07:00
Péter Szilágyi
ab0aaa6b29 core: concurrent background transaction sender ecrecover 2018-07-09 12:14:48 -07:00
Felix Lange
7e103d6fd2 trie: reduce hasher allocations (#16896)
* trie: reduce hasher allocations

name    old time/op    new time/op    delta
Hash-8    4.05µs ±12%    3.56µs ± 9%  -12.13%  (p=0.000 n=20+19)

name    old alloc/op   new alloc/op   delta
Hash-8    1.30kB ± 0%    0.66kB ± 0%  -49.15%  (p=0.000 n=20+20)

name    old allocs/op  new allocs/op  delta
Hash-8      11.0 ± 0%       8.0 ± 0%  -27.27%  (p=0.000 n=20+20)

* trie: bump initial buffer cap in hasher
2018-07-09 12:14:48 -07:00
Elad
736b07f629 vendor: added vendor packages necessary for the swarm-network-rewrite merge (#16792)
* vendor: added vendor packages necessary for the swarm-network-rewrite merge into ethereum master

* vendor: removed multihash deps
2018-07-09 12:14:48 -07:00
kiel barry
82cbe6fd71 params: fix golint warnings (#16853)
params: fix golint warnings
2018-07-09 12:14:46 -07:00
Antonio Salazar Cardozo
ece0d13929 cmd/abigen: support for reading solc output from stdin (#16683)
Allow the --abi flag to be given - to indicate that it should read the
ABI information from standard input. It expects to read the solc output
with the --combined-json flag providing bin, abi, userdoc, devdoc, and
metadata, and works very similarly to the internal invocation of solc,
except it allows external invocation of solc.

This facilitates integration with more complex solc invocations, such
as invocations that require path remapping or --allow-paths tweaks.

Simple usage example:

    solc --combined-json bin,abi,userdoc,devdoc,metadata *.sol | abigen --abi -
2018-07-09 12:13:22 -07:00
Mark
98280f4895 miner: not call commitNewWork if it's a side block (#16751) 2018-07-09 12:13:22 -07:00
Martin Holst Swende
3873e49a10 eth/tracers: fix minor off-by-one error (#16879)
* tracing: fix minor off-by-one error

* tracers: go generate
2018-07-09 12:13:22 -07:00
Felföldi Zsolt
d2a38b30e9 les: add Skip overflow check to GetBlockHeadersMsg handler (#16891) 2018-07-09 12:13:22 -07:00
hadv
5720c7c34c core: fix typo in comment code 2018-07-09 12:13:22 -07:00
Kiel barry
968860b2a2 rpc: golint comments and warnings 2018-07-09 12:13:22 -07:00
Kiel barry
857f70e56b rpc: golint comments 2018-07-09 12:13:22 -07:00
rjl493456442
97dccacf8e cmd/geth: cap cache allowance 2018-07-09 12:13:22 -07:00
Martin Holst Swende
8ef0bcd5b1 rpc: set timeouts for http server, see #16859 2018-07-09 12:13:22 -07:00
Anton Evangelatov
b648297758 metrics: expvar support for ResettingTimer (#16878)
* metrics: expvar support for ResettingTimer

* metrics: use integers for percentiles; remove Overall

* metrics: fix edge-case panic for index-out-of-range
2018-07-09 12:13:22 -07:00
Péter Szilágyi
8251f2e7c5 core, eth, trie: streaming GC for the trie cache (#16810)
* core, eth, trie: streaming GC for the trie cache

* trie: track memcache statistics
2018-07-09 12:13:22 -07:00
Felix Lange
b004ede3ef consensus/ethash: reduce keccak hash allocations (#16857)
Use Read instead of Sum to avoid internal allocations and
copying the state.

name                      old time/op  new time/op  delta
CacheGeneration-8          764ms ± 1%   579ms ± 1%  -24.22%  (p=0.000 n=20+17)
SmallDatasetGeneration-8  75.2ms ±12%  60.6ms ±10%  -19.37%  (p=0.000 n=20+20)
HashimotoLight-8          1.58ms ±11%  1.55ms ± 8%     ~     (p=0.322 n=20+19)
HashimotoFullSmall-8      4.90µs ± 1%  4.88µs ± 1%   -0.31%  (p=0.013 n=19+18)
2018-07-09 12:13:22 -07:00
Ryan Schneider
074bf6b8de rpc: use HTTP request context as top-level context (#16861) 2018-07-09 12:13:22 -07:00
Kiel barry
067dd9700f params: golint warnings, comments 2018-05-31 16:54:12 -07:00
Kiel barry
265576c22e params: golint warnings, comments 2018-05-31 16:53:53 -07:00
kiel barry
af28d12847 console: squash golint warnings (#16836) 2018-05-31 13:59:08 +02:00
kiel barry
0ad32d3be7 ethstats: fix last golint warning (#16837) 2018-05-30 11:36:02 +03:00
Péter Szilágyi
68b0d30d4a
VERSION, params: begin 1.8.11 release cycle 2018-05-30 11:04:45 +03:00