Commit graph

13490 commits

Author SHA1 Message Date
Ömer Faruk Irmak
521a074f60
feat: allow removing txns from pool via CLI/RPC (#1041) 2024-09-16 13:56:11 +03:00
Ömer Faruk Irmak
7f79c7f21f
refactor: eliminate double re-execution in AsyncChecker (#1036) 2024-09-16 11:04:25 +03:00
Ömer Faruk Irmak
6cdcff6275
fix: reuse timestamp for blocks failing CCC (#1031)
we assume that same height wont trigger multiple reorgs to be able
to put an upper bound on the reorg depth. We rely on the fact that
AsyncChecker executes transactions one-by-one and tells worker the
safe set of transactions to include in the replacement block that
wont trigger another error on the same block. If worker changes the
timestamp and that causes significant changes to the execution flow
of included transactions; we might have a height where multiple
reorgs happen.
2024-09-10 14:59:42 +03:00
Ömer Faruk Irmak
51082b29c5
fix: properly handle wrapped retryable errors (#1030)
* fix: properly handle wrapped retryable errors

* chore: auto version bump [bot]

---------

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: Thegaram <Thegaram@users.noreply.github.com>
2024-09-09 18:37:32 +02:00
Ömer Faruk Irmak
e426d4bffa
fix: ignore RC check if force committing (#1029)
* fix: ignore RC check if force committing

* rename force to reorging

* use prev goimports version
2024-09-09 18:31:22 +02:00
Ömer Faruk Irmak
590e104111
fix: increase keccak usage safety buffer (#1028) 2024-09-09 18:48:12 +03:00
Zhang Zhuo
665f6c3413
feat(rpc): add getTxByTxTrace api, used for ccc testing & debugging (#1026)
* ++

* upgrade go lint version

* lint

* remove a useless "`"

* Update l2geth_ci.yml

---------

Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
2024-09-06 23:22:47 +08:00
Ömer Faruk Irmak
a4b738f815
fix: skip ccc.ErrUnknown txns immediately (#1027) 2024-09-06 16:12:53 +03:00
Ömer Faruk Irmak
bf5cca7c29
fix: nil-check curRc (#1024)
* fix: nil-check curRc

* chore: auto version bump [bot]

---------

Co-authored-by: omerfirmak <omerfirmak@users.noreply.github.com>
2024-09-05 15:15:24 -07:00
Ömer Faruk Irmak
bdb1ffb97a
feat: add miner idle metric (#1023) 2024-09-05 17:50:04 +03:00
Ömer Faruk Irmak
e0203bf9b7
feat: double check ancestor RowConsumption before committing (#1022) 2024-09-05 16:54:12 +03:00
Ömer Faruk Irmak
0573f6e440
fix: disable headCCCCheck for follower nodes (#1021) 2024-09-05 13:38:45 +03:00
HAOYUatHZ
8f8ef30931
feat(txpool): add more logs to runReorg (#1019)
* feat(txpool): add more logs to `runReorg`

* chore: auto version bump [bot]

* improve

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
2024-09-05 09:31:49 +10:00
Ömer Faruk Irmak
e9259b783f
feat: implement and integrate counter-based CCC (#982)
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
Co-authored-by: Xi Lin <zimpha@gmail.com>
2024-09-04 13:33:51 +03:00
HAOYUatHZ
2865e13e5b
fix(metrics): fix tx broadcast investigation metrics again (#1012)
* update eth/protocols/eth/broadcast.go

* chore: auto version bump [bot]

* update eth/protocols/eth/handlers.go

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
2024-08-28 20:17:49 +10:00
HAOYUatHZ
89e9a21577
fix(metrics): fix tx broadcast investigation metrics (#1010)
* update eth/protocols/eth/broadcast.go

* update eth/protocols/eth/handlers.go

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
2024-08-28 15:11:35 +10:00
HAOYUatHZ
118a80b734
feat: add more metrics to investigate tx broadcast issue (#1007)
* update eth/fetcher/tx_fetcher.go

* update eth/handler.go

* update eth/handler.go

* update eth/protocols/eth/peer.go

* update eth/protocols/eth/broadcast.go

* update eth/protocols/eth/handlers.go

* chore: auto version bump [bot]

* fix

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
2024-08-27 23:03:26 +02:00
HAOYUatHZ
77a565943f
feat: add more logs to investigate tx broadcast issue (#1005)
* 1. broadcast + announce

* 2. broadcast

* 3. broadcast

* 5. announce

* 6. announce

* 7. announce

* 8. announce

* 9. announce

* 10. announce

* minor

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
2024-08-27 14:06:13 +02:00
colin
c252ee1ee0
feat(tx-pool): fast reject known skipped txs (#1004)
* feat(tx-pool): fast reject known skipped txs (#1001)

* feat(tx-pool): fast reject known skipped txs

* fix make lint

* add miner flag to tx pool

* bump version
2024-08-26 22:48:44 +08:00
Péter Garamvölgyi
ff23c5272a
feat: schedule DarwinV2 (#1002)
* refactor: add darwinV2 to tests, improve log format

* feat: schedule DarwinV2
2024-08-26 16:15:56 +02:00
colin
03f3b2b60d
fix(rollup-verifier): delete committed batch meta when reverting a batch (#1000)
* fix(rollup-verifier): delete committed batch metadata when reverting a batch

* chore: auto version bump [bot]

* remove a comment

---------

Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
2024-08-26 11:15:29 +02:00
Ömer Faruk Irmak
233a6adc15
feat: async ccc checker (#996) 2024-08-23 11:04:12 +03:00
Dragan Milic
972fe8afc4
feat: backport flatCallTracer (#895) 2024-08-23 09:52:00 +03:00
colin
9de4980851
feat(rollup-verifier): codecv4 (#991)
* feat(rollup-verifier): codecv4

* fix golint

* enhancements

* rename

* rename

* feat: add darwinv2 in genesis config

* bump version

* fix typo

* Update params/config.go

Co-authored-by: georgehao <haohongfan@gmail.com>

* add DarwinV2

* address comments

* move a comment to other places

* small refactors

* chore: auto version bump [bot]

* update da-codec commit

* fix a bug

---------

Co-authored-by: georgehao <haohongfan@gmail.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
2024-08-23 14:50:08 +08:00
colin
0ed16b0739
feat: add darwinv2 in genesis config (#993)
* feat: add darwinv2 in genesis config

* bump version

* fix typo

* Update params/config.go

Co-authored-by: georgehao <haohongfan@gmail.com>

---------

Co-authored-by: georgehao <haohongfan@gmail.com>
2024-08-21 18:36:21 +02:00
georgehao
2ccacff1bf
feat(metrics): calculate the real pending tx (#983)
* calculate the real pending tx

* update

* move realPendingTx to miner

* update

* calculate the real pending tx by statsWithMinBaseFee

* update

* fix lint

* address comments

* add metrics to StatsWithMinBaseFee

* change read_lock to write_lock
2024-08-20 15:39:28 +08:00
georgehao
4b85bbcbd8
calculate tx the lifecycle duration (#839)
* feat: add transactions len metrics of block processer

* calculate tx lifecycle median duration

* chore: auto version bump [bot]

* fix

* fix

* fix

* chore: auto version bump [bot]

* address comments

* remove error code

* address comment

* update

* Update core/tx_pool.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* Update core/types/transaction.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* Update core/tx_pool.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* Update core/tx_pool.go

---------

Co-authored-by: georgehao <georgehao@users.noreply.github.com>
Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
2024-08-13 16:45:01 +08:00
Ömer Faruk Irmak
096b98a85c
feat: allow calculating diffs between two row consumptions (#980) 2024-08-12 22:22:38 +03:00
Ömer Faruk Irmak
4464f48a5d
refactor: remove unused unconfirmed.go (#972) 2024-08-12 13:08:42 +03:00
oksanaphmn
4d83d8954e
Fix typo README (#979)
Fix typo README
2024-08-12 11:28:56 +08:00
Ömer Faruk Irmak
2411ae063e
refactor: rename CCC package for less repetition (#967) 2024-08-09 08:21:14 +03:00
Zhang Zhuo
3f5fb275ef
fix: enable correct string encoding of new opcodes (#815) 2024-08-08 13:11:26 +03:00
Péter Garamvölgyi
dfd4039be7
feat: schedule Darwin hard fork (#963) 2024-08-05 09:13:29 +02:00
Ömer Faruk Irmak
2ba5ea3058
Revert "refactor: reduce number of heap allocations in tracing (#952)" (#959)
This reverts commit b84f4ed6f8.
2024-08-02 21:59:50 +08:00
HAOYUatHZ
ee0410ec10
feat: update L2 base fee formula (#951)
* update `CalcBaseFee`

* update `TestCalcBaseFee`

* update `TestStateProcessorErrors`

* bump version

* update threshold
2024-08-02 10:09:33 +08:00
Ömer Faruk Irmak
b84f4ed6f8
refactor: reduce number of heap allocations in tracing (#952) 2024-08-01 14:52:43 +03:00
Ömer Faruk Irmak
51c7eee1e4
feat(clique): allow shadowforking a clique network (#828) 2024-08-01 12:11:00 +03:00
Ömer Faruk Irmak
9abdd5b9aa
feat: defer txpool reorg until worker fetches txns for the next block (#905) 2024-07-26 10:25:58 +03:00
Ömer Faruk Irmak
e3bfb5fd46
fix: treat JSON errors as CCC error (#922) 2024-07-25 17:35:32 +03:00
georgehao
df3713e840
feat(libzkp):unbounded depth serde json (#920)
* feat: add transactions len metrics of block processer

* fix

* format

* chore: auto version bump [bot]

* remove unusd code

---------

Co-authored-by: georgehao <georgehao@users.noreply.github.com>
2024-07-24 11:59:30 +08:00
Péter Garamvölgyi
f2af32d3d5
fix: log Rust trace parsing error (#918)
* fix: log Rust trace parsing error

* fix
2024-07-24 01:47:47 +02:00
HAOYUatHZ
9ee6976fe5
fix(miner,rpc): fix updateSnapshot (#916)
* fix `updateSnapshot`

* fix

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
2024-07-23 22:22:51 +08:00
colin
de0385e7d2
fix(verifier): nil panic due to batch write (#911) 2024-07-20 00:39:28 +08:00
colin
0360eba836
fix(l2geth-verifier): only check last batch of the bundle (#904)
* fix(l2geth-verifier): only check the last batch of each bundle

* refactor function comments

* add more logs to debug

* fix the bug

* Revert "add more logs to debug"

This reverts commit 4befe9fe739275988b4bf34999bd1aad4d7a1d0e.

* tweak

* TestValidateBatchInFinalizeByBundle

* update da-codec dependency

* move rawdb.WriteFinalizedBatchMeta outside the loop

* use batch writer

* change log.Crit to log.Error
2024-07-17 20:01:40 +08:00
Zhang Zhuo
0cecc1986e
refactor(trace): clean outdated fields (#842)
* clean trace: remove ExtraData, disable prestateTracer, collect bytecodes in top level

* fix

* fix

* fix

* fix

* fix

* more cleanup

* more cleanup

* refactor(trace): clean outdated fields

* fix bytecodes in trace

* chore: auto version bump [bot]

* chore: auto version bump [bot]

* use hexutil.Bytes

---------

Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Co-authored-by: omerfirmak <omerfirmak@users.noreply.github.com>
Co-authored-by: lispc <lispc@users.noreply.github.com>
2024-07-15 20:36:00 +08:00
colin
df08f60183
fix(rollup-verifier): decode commitBatchWithBlobProof calldata (#896)
fix(rollup-verifier): decode commitBatchWithBlobProof

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
2024-07-13 00:37:31 +08:00
Péter Garamvölgyi
0b5146bdef
feat(txpool): use GasFeeCapIntCmp to check min fee (#901)
* feat(txpool): use GasFeeCapIntCmp to check min fee

* fix test
2024-07-12 11:56:35 +02:00
HAOYUatHZ
55f70cc6e8
fix(tracing): fix error handling in fillBlockTrace (#890)
* fix(tracing): fix error handling in `fillBlockTrace`

* chore: auto version bump [bot]

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com>
2024-07-11 18:58:07 +08:00
Ömer Faruk Irmak
c3371e2b07
fix: return early as expected when engine.Prepare fails (#886) 2024-07-11 11:51:02 +03:00
Jonas Theis
8c7a3aed74
feat(txpool): StatsWithMinBaseFee (#884)
* feat(txpool): implement StatsWithMinBaseFee

* feat(gpo): use StatsWithMinBaseFee to filter out tx below the current blocks base fee

* feat(les/txpool): implement StatsWithMinBaseFee

* use flatten() (lowercase) to avoid copying of tx list

* chore: auto version bump [bot]

---------

Co-authored-by: jonastheis <jonastheis@users.noreply.github.com>
2024-07-10 11:10:58 +02:00