mirror of
https://github.com/ethereum/go-ethereum.git
synced 2026-07-28 07:36:44 +00:00
5ae1b16970
* dev: chg: update PR template to include nodes audience check * dev: chg: better description * dev: chg: add entry to changes too
49 lines
1.7 KiB
Markdown
49 lines
1.7 KiB
Markdown
# Description
|
|
|
|
Please provide a detailed description of what was done in this PR
|
|
|
|
# Changes
|
|
|
|
- [ ] Bugfix (non-breaking change that solves an issue)
|
|
- [ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
|
|
- [ ] New feature (non-breaking change that adds functionality)
|
|
- [ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
|
|
- [ ] Changes only for a subset of nodes
|
|
|
|
# Breaking changes
|
|
|
|
Please complete this section if any breaking changes have been made, otherwise delete it
|
|
|
|
# Nodes audience
|
|
|
|
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
|
|
|
|
# Checklist
|
|
|
|
- [ ] I have added at least 2 reviewer or the whole pos-v1 team
|
|
- [ ] I have added sufficient documentation in code
|
|
- [ ] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
|
|
|
|
# Cross repository changes
|
|
|
|
- [ ] This PR requires changes to heimdall
|
|
- In case link the PR here:
|
|
- [ ] This PR requires changes to matic-cli
|
|
- In case link the PR here:
|
|
|
|
## Testing
|
|
|
|
- [ ] I have added unit tests
|
|
- [ ] I have added tests to CI
|
|
- [ ] I have tested this code manually on local environment
|
|
- [ ] I have tested this code manually on remote devnet using express-cli
|
|
- [ ] I have tested this code manually on mumbai
|
|
- [ ] I have created new e2e tests into express-cli
|
|
|
|
### Manual tests
|
|
|
|
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
|
|
|
|
# Additional comments
|
|
|
|
Please post additional comments in this section if you have them, otherwise delete it
|